Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove unnecessary vertical scroll in All Issues Tabs. #3300

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

prateekshourya29
Copy link
Collaborator

Problem

PLE-189 : All issues > navigation for detailed view is showing unnecessary scroll in Safari, firefox & chrome browser.

Solution

Made changes in the Navigation tabs style to allow horizontal scroll only to the views links and not the entire section.

Before and After Fix

all-issues-scroll.mp4

<div className="group relative flex border-b border-custom-border-200">
<div className="flex w-full items-center overflow-x-auto px-4">
{DEFAULT_GLOBAL_VIEWS_LIST.map((tab) => (
<Link key={tab.key} href={`/${workspaceSlug}/workspace-views/${tab.key}`}>

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
web/components/workspace/views/header.tsx Fixed Show fixed Hide fixed
@sriramveeraghanta sriramveeraghanta merged commit b58d7a7 into develop Jan 3, 2024
7 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the style/all-issues branch January 3, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants