Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: preview to master #3281

Merged
merged 51 commits into from
Dec 29, 2023
Merged

release: preview to master #3281

merged 51 commits into from
Dec 29, 2023

Conversation

sriramveeraghanta
Copy link
Contributor

@sriramveeraghanta sriramveeraghanta commented Dec 29, 2023

Improvements

  • Added a 20 Character limit to estimate points during the creation process. (#3188)
  • We have updated the hint text for email placeholders across the platform. (#3206)
  • Creating a project with non-Latin characters in its identifier is now allowed. (#3226)
  • Create webhook page is transformed to modal. (#3223)
  • We enhanced the Module and Cycle sidebars by adding a 'No Lead' option in modules and improving the date selection UI. (#3251)
  • Added links to dashboard summary items, workspace sidebar dropdown & sidebar. (#3281)
  • Improved the header title for All issues to be consistent across the platform. (#3269)
  • Now the current statuses of the cycle like CURRENT, UPCOMING, COMPLETED and DRAFT will be sent in the response of the cycle. (#3270)

Bug Fixes

  • Added additional headers to restrict iframe.
  • Fixed the issue where admins & members were not able to view the CTA on empty state screens for creating a project. (#3204)
  • Resolved issues where pages' contents were not getting saved on editing a page or making a copy of the page. (#3203)
  • Fixed a typo in the empty state screen for Project Labels screen. (#3120) (daveanthonyc)
  • Add DATA_UPLOAD_MAX_MEMORY_SIZE in plane.settings.production with a value equal to FILE_SIZE_LIMIT. (#3160) (luandnh)
  • We have made some design updates to the Instance Admin Panel’s Email settings to maintain design consistency across the platform. (#3186)
  • We have addressed the issue where the 'Save Draft Issue' modal was triggering upon discarding an empty issue creation process in some cases. (#3218)
  • We have resolved the scroll issues on empty state screens for Pages. (#3218)
  • We resolved the issue where creating issues with Quick Add didn't occupy the full width for titles. (#3218)
  • Fixed the issue where the workspace member invitation modal was not resetting to empty modal after the invitation had been sent. (#3189)
  • Fixes the bug where image was not being inserted in the cursor's current position. (#3224)
  • Fixes CSS issues with Images during insert (content shift). (#3224)
  • Fixed types for slash commands by inspecting generics. (#3281)
  • The problem occurs from a recent code refactoring, causing the removal of necessary default values. I've rectified this by implementing a validation: if no palette is available, the theme won't be applied. (#3246)
  • Fixed issues with pages mutation on component mount. (#3230)
  • Replacing all button click editions with nextjs link tags to enables the browser functionalities like copy address. (#3263)
  • Fixed the issue where issue activity was overflowing in the Peek Overview in the platform. (#3269)
  • We have fixed the issue where upon sign up, the user was getting looped in the onboarding screen unless refreshed. (#3250)
  • Rectified the issues with the Copied links by removing the extra slash at the beginning. (#3250)
  • Fixed inconsistencies with next_url and next_path in various locations, addressing a security vulnerability due to lack of validation for the next_path URL. (#3250)
  • Added issue title to the activity. (#3271)
  • Fixed the issue where when clicking the parent issue button area, the selection is cleared instead of opening the modal. - Only the 'x' icon should deselect the selection. Resolved this by designing two buttons within a div to function independently. (#3267)
  • Removed Save View option from the header for Guest/ Viewers. (#3260)
  • Disabled Date and Label properties with proper styling for all views for Guest/ Viewers. (#3260)
  • Since the proxy server is running with Nginx, it is recommended to add the relevant proxy header to use Web Socket. The relevant documentation is shared below. (#3196) (abidkhan484)
  • Fixed workspace invitation status by implementing new status like account not created and rejected values. (#3279)

Security

  • CLICKJACKING is disabled on the platform for better security. (#3281)

sriramveeraghanta and others added 30 commits December 20, 2023 13:49
This commit adds a duplicate_page function to the PageDetailsPage component, which allows users to duplicate a page. If the current page does not have a description_html value, it will be set to the default value from the pageDetails object. The formData object is updated with the necessary values for duplication, including the new page name and description. Additionally, the handleSubmit dependency is included in the useEffect hook to ensure proper form submission.
* fix: posthog events trigger in staging

* refactor: cleared comment lines for warnings, added dependancy values

* refactor: removed unnecessary dependency
fix: posthog events trigger in staging (#3220)
fix: branch build custom docker repo with suffix (#3182)
* branch build fix for release-* in case of space,backend,proxy

* fixes
* fix - file size limit not work on plane.settings.production

* fix - file size limit not work on plane.settings.production

* fix - file size limit not work on plane.settings.production, move to common.py

---------

Co-authored-by: luanduongtel4vn <hoangluan@tel4vn.com>
Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com>
* chore: draft issue validation added to prevent saving empty or whitespace title

* chore: resolve scrolling issue in page empty state

* chore: kanban layout quick add issue improvement
* fix: workspace invitation modal form values reset

* fix: profile sidebar avatar letter
* removed relative imports from editor core

* Update issue widget file paths and imports to use kebab case instead of camel case, to align with coding conventions and improve consistency.

* Update Tiptap core and extensions versions to 2.1.13 and Tiptap React version to 2.1.13. Update Tiptap table imports to use the new location in package @tiptap/pm/tables. Update AlertLabel component to use the new type definition for LucideIcon.

* updated lock file

* removed default exports from editor/core

* fixed injecting css into the core package itself

* seperated css code to have single source of origin wrt to the package

* removed default imports from document editor

* all instances using index as key while mapping fixed

* Update Lite Text Editor package.json to remove @plane/editor-types as a dependency.

Update Lite Text Editor index.ts to update the import of IMentionSuggestion and IMentionHighlight from @plane/editor-types to @plane/editor-core.

Update Lite Text Editor ui/index.tsx to update the import of UploadImage, DeleteImage, IMentionSuggestion, and RestoreImage from @plane/editor-types to @plane/editor-core.

Update Lite Text Editor ui/menus/fixed-menu/index.tsx to update the import of UploadImage from @plane/editor-types to @plane/editor-core.

Update turbo.json to remove @plane/editor-types#build as a dependency for @plane/lite-text-editor#build, @plane/rich-text-editor#build, and @plane/document-editor#build.

* Remove deprecated import and adjust tippy.js usage in the slash-commands.tsx file of the editor extensions package.

* Update dependencies in `rich-text-editor/package.json`, remove `@plane/editor-types` and add `@plane/editor-core` in `rich-text-editor/src/index.ts`, and update imports in `rich-text-editor/src/ui/extensions/index.tsx` and `rich-text-editor/src/ui/index.tsx` to use `@plane/editor-core` instead of `@plane/editor-types`.

* Update package.json dependencies and add new types for image deletion, upload, restore, mention highlight, mention suggestion, and slash command item.

* Update import statements in various files to use the new package "@plane/editor-core" instead of "@plane/editor-types".

* fixed document editor to follow conventions

* Refactor imports in the Rich Text Editor package to use relative paths instead of absolute paths.

- Updated imports in `index.ts`, `ui/index.tsx`, and `ui/menus/bubble-menu/index.tsx` to use relative paths.
- Updated `tsconfig.json` to include the `baseUrl` compiler option and adjust the `include` and `exclude` paths.

* Refactor Lite Text Editor code to use relative import paths instead of absolute import paths.

* Added LucideIconType to the exports in index.ts for use in other files.
Created a new file lucide-icon.ts which contains the type LucideIconType.
Updated the icon type in HeadingOneItem in menu-items/index.tsx to use LucideIconType.
Updated the Icon type in AlertLabel in alert-label.tsx to use LucideIconType.
Updated the Icon type in VerticalDropdownItemProps in vertical-dropdown-menu.tsx to use LucideIconType.
Updated the Icon type in BubbleMenuItem in fixed-menu/index.tsx to use LucideIconType.
Deleted the file tooltip.tsx since it is no longer used.
Updated the Icon type in BubbleMenuItem in bubble-menu/index.tsx to use LucideIconType.

* ♻️ refactor: simplify rendering logic in slash-commands.tsx

The rendering logic in the file "slash-commands.tsx" has been simplified. Previously, the code used inline positioning for the popup, but it has now been removed. Instead of appending the popup to the document body, it is now appended to the element with the ID "tiptap-container". The "flip" option has also been removed. These changes have improved the readability and maintainability of the code.

* fixed build errors caused due to core's internal imports

* regression: fixed pages not saving issue and not duplicating with proper content issue

* build: Update @tiptap dependencies

Updated the @tiptap dependencies in the package.json files of `document-editor`, `extensions`, and `rich-text-editor` packages to version 2.1.13.

* 🚑 fix: Correct appendTo selector in slash-commands.tsx

Update the `appendTo` function call in `slash-commands.tsx` to use the correct selector `#editor-container` instead of `#tiptap-container`. This ensures that the component is appended to the appropriate container in the editor extension.

Note: The commit message assumes that the change is a fix for an issue or error. If it's not a fix, please provide more context so that an appropriate commit type can be determined.
* style: email placeholder changed across the platform

* fix: placeholder text
…lder text. (#3224)

* Fix position bug in the UploadImagesPlugin widget decoration and adjust transaction to correctly insert image node and set meta data for image removal.

* Update CSS styles in editor.css to remove margin top and bottom on images and img placeholders and adjust the margin on the table in the editor container.

* Better typescript support for images extension.

Update the `Command` extension in `slash-commands.tsx` to include a `SlashCommandOptions` type for better TS support and allow spaces in the suggestion options and modify the `image` suggestion's search terms to include "img" in addition to "photo", "picture", and "media".
fix: moving patch fixes from release 0.15 to 0.14.2
fix: Fixed types for slash commands by inspecting generics
* style: create webhook page to modal

* fix: create page removed

* fix: auto modal close on empty state

* fix: secret key heading removed from generated modal
promote: moving stable changes from develop to preview
* 🔧 chore: Update revalidate option and add useEffect hook in PageDetailsPage component

- Set the `revalidate` option to `false` in the `commonSwrOptions` object.
- Add an `useEffect` hook that calls the `mutatePageDetails` function with specific options.
- Inside the `useEffect` hook, set `revalidate` to `true`, `populateCache` to `true`, and define a rollback function for error handling.
- If an error occurs during the rollback, display an error alert message using the `actionCompleteAlert` function.
- In the `updatePage` function, ensure that `workspaceSlug`, `projectId`, and `pageId` are all defined before proceeding.

* ♻️ refactor: Update code styling for inline code in CoreEditorExtensions

In the `packages/editor/core/src/ui/extensions/index.tsx` file, the code for inline code styling in the CoreEditorExtensions component has been updated. Previously, it was set to `false`, but now it is defined as an object with specific HTML attributes. The code styling includes a rounded-md background, custom primary color, margin, padding, font styling, and disabling spellcheck. This change improves the visual appearance and readability of inline code elements in the editor.
* fix: adding token to the build pr workflow

* fix: using automatic github token
promote: develop to preview
sriramveeraghanta and others added 21 commits December 26, 2023 19:00
fix: adding access token to build Pr (#3257)
* chore: no lead option added in module lead select dropdown

* chore: module lead select dropdown code refactor

* chore: cycle sidebar improvement

* chore: module sidebar improvement

* style: cycle and module sidebar improvement

* style: app sidebar improvement
* fix: passed workspace id and project id as context

* fix: issue activity
* chore: validations and bug fixes

* chore: estimate point character limit validation

---------

Co-authored-by: LAKHAN BAHETI <lakhanbaheti9@gmail.com>
* fix: adding links to dashboard summary items

* fix: adding links to workspace sidebar dropdown

* fix: adding links to the sidebar
* style: update `Workspace Issues` -> `All Issues` header.

* style: fix issue activity text overflow issue.
* chore: try and catch added in handleSignInRedirection

* chore: remove unnecessary hooks

* fix: handleCopyIssueLink url updated

* chore: swap next_url with next_path and validate redirection logic for next_path url
* dev: cycle status

* chore: cycle status logic updated

---------

Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so>
* chore: remove `Save View` option for guest/ viewer from project issues header.

* chore: allow guest/ viewer to clear applied filters in project issues.

* chore: disable `date`, `label` property access for guests/ viewer in all project issue views.

* chore: update `Workspace Issues` -> `All Issues` header.

* chore: refactor apply/ clear filter implementation in All Issues.

* Revert "chore: refactor apply/ clear filter implementation in All Issues."

This reverts commit 024822d.

* Revert "chore: allow guest/ viewer to clear applied filters in project issues."

This reverts commit 3dae871.

* Revert "chore: update `Workspace Issues` -> `All Issues` header."

This reverts commit 03f90be.

* chore: remove `cursor-pointer` style from non actionable issue properties.
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319
promote: develop changes to preview
@sriramveeraghanta sriramveeraghanta merged commit 28a9c53 into master Dec 29, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.