Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/user role validation #3260

Merged
merged 9 commits into from
Dec 29, 2023
Merged

Chore/user role validation #3260

merged 9 commits into from
Dec 29, 2023

Conversation

prateekshourya29
Copy link
Collaborator

@prateekshourya29 prateekshourya29 commented Dec 27, 2023 •
edited
Loading

Problem

  1. Guests and Viewers could access the 'Save View' button, causing errors due to restricted access.
  2. Guests and Viewers could access Date and Label properties even without access.

Solution

  1. Removed Save View option from the header for Guest/ Viewers.

Before Fix

image

After Fix

image

  1. Disabled Date and Label properties with proper styling for all views.
    https://github.com/makeplane/plane/assets/33979846/461ab417-db26-4ef6-add3-63517e92d8d3

@prateekshourya29 prateekshourya29 added this to the v0.15-dev milestone Dec 27, 2023
@prateekshourya29 prateekshourya29 marked this pull request as draft December 27, 2023 09:21
@prateekshourya29 prateekshourya29 changed the title Chore/user role validation Chore/user role validation and add/ remove filter refactor Dec 27, 2023
@prateekshourya29 prateekshourya29 marked this pull request as ready for review December 28, 2023 08:53
@prateekshourya29 prateekshourya29 changed the title Chore/user role validation and add/ remove filter refactor Chore/user role validation Dec 28, 2023
@sriramveeraghanta sriramveeraghanta merged commit f132fe5 into develop Dec 29, 2023
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/user-role-validation branch December 29, 2023 11:05
@rhea0110 rhea0110 mentioned this pull request Dec 29, 2023
Merged
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@prateekshourya29 @sriramveeraghanta
Chore/user role validation (#3260)
a545787 
* chore: remove `Save View` option for guest/ viewer from project issues header.

* chore: allow guest/ viewer to clear applied filters in project issues.

* chore: disable `date`, `label` property access for guests/ viewer in all project issue views.

* chore: update `Workspace Issues` -> `All Issues` header.

* chore: refactor apply/ clear filter implementation in All Issues.

* Revert "chore: refactor apply/ clear filter implementation in All Issues."

This reverts commit 024822d.

* Revert "chore: allow guest/ viewer to clear applied filters in project issues."

This reverts commit 3dae871.

* Revert "chore: update `Workspace Issues` -> `All Issues` header."

This reverts commit 03f90be.

* chore: remove `cursor-pointer` style from non actionable issue properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@aaryan610 aaryan610 aaryan610 approved these changes

Assignees
No one assigned
Labels
🌐frontend 🎨UI / UX
Projects
None yet
Milestone
v0.14.2-dev
Development

Successfully merging this pull request may close these issues.
3 participants
@prateekshourya29 @sriramveeraghanta @aaryan610