-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: posthog events trigger in staging #3220
Conversation
web/lib/wrappers/posthog-wrapper.tsx
Outdated
@@ -48,7 +48,7 @@ const PosthogWrapper: FC<IPosthogWrapper> = (props) => { | |||
}); | |||
} | |||
// eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix any issue with exhaustive-deps
web/lib/wrappers/posthog-wrapper.tsx
Outdated
@@ -60,8 +59,7 @@ const PosthogWrapper: FC<IPosthogWrapper> = (props) => { | |||
return () => { | |||
router.events.off("routeChangeComplete", handleRouteChange); | |||
}; | |||
// eslint-disable-next-line react-hooks/exhaustive-deps | |||
}, []); | |||
}, [router.events]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not required here.
fix: posthog events trigger in staging (#3220)
This PR contains the fix for PostHog events which are not getting triggered in staging and production.