fix: Resolved page not saving/not copying contents bug #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a duplicate_page function to the PageDetailsPage component, which allows users to duplicate a page. If the current page does not have a description_html value, it will be set to the default value from the pageDetails object. The formData object is updated with the necessary values for duplication, including the new page name and description. Additionally, the handleSubmit dependency is included in the useEffect hook to ensure proper form submission.
1 task
sriramveeraghanta
approved these changes
Dec 20, 2023
sriramveeraghanta
deleted the
fix/page-not-saving-not-copying-content
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fix to the
duplicatePagefunction, which allows users to duplicate a page even before they start typing in the editor i.e. if the current page's form does not have adescription_htmlvalue yet i.e. on editor initialisation, it will be set to the default value from thepageDetailsobject fetched from the backend via SWR. TheformDataobject is updated with the necessary values for duplication, including the new/updated page name and description.Additionally to fix the patch call not being made on typing, the handleSubmit dependency of
pageDetailsis included in the useCallback hook of the debounce function to ensure proper form submission such that thenamefield is always updated for theupdatePagefunction as it's wrapped in useCallback.