Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix websocket connection issue in docker makeplane/plane#3195 #3196

Merged
merged 3 commits into from
Dec 29, 2023
Merged

fix websocket connection issue in docker makeplane/plane#3195 #3196

merged 3 commits into from
Dec 29, 2023

Conversation

abidkhan484
Copy link
Contributor

Since the proxy server is running with Nginx, it is recommended to add the relevant proxy header to use Web Socket. The relevant documentation is shared below.

Reference: Nginx WebSocket Proxying documentation

mguptahub
mguptahub requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@mguptahub mguptahub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix and revert.

nginx/nginx.conf.template Outdated Show resolved Hide resolved
@abidkhan484 abidkhan484 deleted the fix-websocket-docker-setup branch December 20, 2023 14:21
@abidkhan484 abidkhan484 restored the fix-websocket-docker-setup branch December 20, 2023 14:27
@abidkhan484 abidkhan484 reopened this Dec 20, 2023
mguptahub
mguptahub approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@mguptahub mguptahub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@abidkhan484
Copy link
Contributor Author

good to go

Thank you for your thorough review of my pull request. Your insights were incredibly helpful, and I appreciate your time and expertise.

@sriramveeraghanta sriramveeraghanta merged commit f200acc into makeplane:preview Dec 29, 2023
3 checks passed
@abidkhan484 abidkhan484 deleted the fix-websocket-docker-setup branch December 29, 2023 12:05
@rhea0110 rhea0110 mentioned this pull request Dec 29, 2023
Merged
@sriramveeraghanta sriramveeraghanta linked an issue Dec 30, 2023 that may be closed by this pull request
[bug]: Websocket connection to the proxy server failed while set up with docker compose file #3195
Closed
1 task
@sriramveeraghanta sriramveeraghanta added this to the v0.14.2-dev milestone Dec 30, 2023
@abidkhan484 abidkhan484 restored the fix-websocket-docker-setup branch January 1, 2024 10:15
abidkhan484 added a commit to abidkhan484/plane that referenced this pull request Jan 1, 2024
@abidkhan484
Revert "fix websocket connection issue in docker makeplane#3195 (make…
aa0400b 
…plane#3196)"

This reverts commit f200acc.
abidkhan484 added a commit to abidkhan484/plane that referenced this pull request Jan 1, 2024
@abidkhan484
fix env substitution issue of proxy_set_header makeplane#3196
9690387
mguptahub added a commit that referenced this pull request Jan 10, 2024
@abidkhan484 @mguptahub
Fix env substitute issue in websocket docker setup (#3296)
a70f551 
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319

* fix env substitution issue  of proxy_set_header #3196

* review fixes

---------

Co-authored-by: Manish Gupta <manish@mgupta.me>
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@abidkhan484 @sriramveeraghanta
fix websocket connection issue in docker #3195 (#3196)
2b5c293 
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@abidkhan484 @mguptahub @sriramveeraghanta
Fix env substitute issue in websocket docker setup (#3296)
fff6ee6 
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319

* fix env substitution issue  of proxy_set_header #3196

* review fixes

---------

Co-authored-by: Manish Gupta <manish@mgupta.me>
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@abidkhan484 @mguptahub @sriramveeraghanta
Fix env substitute issue in websocket docker setup (#3296)
38580c3 
* fix websocket connection issue in docker #3195

* fix websocket connection issue for local env with removing from the prod nginx conf template #319

* fix env substitution issue  of proxy_set_header #3196

* review fixes

---------

Co-authored-by: Manish Gupta <manish@mgupta.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@mguptahub mguptahub mguptahub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.2-dev
Development

Successfully merging this pull request may close these issues.

[bug]: Websocket connection to the proxy server failed while set up with docker compose file
3 participants
@abidkhan484 @sriramveeraghanta @mguptahub