Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Improved keyboard support #5965

Closed
1 task done
NielsCodes opened this issue Nov 6, 2024 · 2 comments
Closed
1 task done

[feature]: Improved keyboard support #5965

NielsCodes opened this issue Nov 6, 2024 · 2 comments

Comments

@NielsCodes
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Keyboard navigation is not consistent and sometimes does not follow common behavior.

Some examples:

  • In the create new issue modal, it's possible to press Tab to move from the Title to the Body, but you're not able to move back with shift + tab
  • Selecting some text and pressing CMD + K opens the command bar, instead of making the selected text a link like it would in almost every other text editor
  • Shift + Enter creates the issue in a "normal" New Issue modal, but not in the Intake New Issue modal (Fixed in 0.23)

I'd be happy to create a PR for this myself. I would like to use this issue to collect other feedback on missing or wrong keyboard shortcut implementations as well.

Why should this be worked on?

Keyboard navigation is important for accessibility. And keyboard shortucts that go against common behaviour (such as creating a link) can be quite frustrating.

@aaryan610
Copy link
Collaborator

@NielsCodes thanks for pointing this out, the focus/blur functionality in our editors is a little messed up as you mentioned, we'll try to fix it real soon.

@Palanikannan1437
Copy link
Collaborator

Hey @NielsCodes, this is now fixed thanks to these slick contributions (#6569 and #6554) by @VipinDevelops 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants