Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geordi commit: Pass arbitrary arguments to the git command #71

Closed
makmic opened this issue Jul 29, 2019 · 4 comments
Closed

geordi commit: Pass arbitrary arguments to the git command #71

makmic opened this issue Jul 29, 2019 · 4 comments
Assignees

Comments

@makmic
Copy link
Member

makmic commented Jul 29, 2019

It would be nice if geordi would relay every unused argument for geordi commit to the underlying git command. This can be helpful i.e. to create an initially empty commit with the sole purpose to be squashed upon:

git checkout -b my-new-branch
geordi commit
# nothing to commit, working directory clean

If geordi would relay my arguments to git, the following would be possible:

git checkout -b my-new-branch
geordi commit --alow-empty
# [my-new-branch] Pivotal Story Message here
@denzelem
Copy link
Contributor

Thanks @makmic for your suggestion. I think it would make sense to allow this in Geordi.

As you can see there are some more issues open, which partially have a higher priority. That means it could take a while until this feature will be implemented.

Nevertheless I will be happy to review a PR in case you have time to implement this on your own.

@makmic
Copy link
Member Author

makmic commented Jul 30, 2019

Thank you for looking into and priorizing the issue. I do not expect to free up time in the near future to create a PR by myself, but I'll let you know if i do 😉

@codener codener self-assigned this Nov 15, 2019
@codener
Copy link
Member

codener commented Nov 25, 2019

@makmic In the just released 2.7.0, geordi commit will make empty commits by default (but print a warning). Arguments are forwarded to git nontheless and allow further customization.

@makmic
Copy link
Member Author

makmic commented Nov 25, 2019

Thank you for looking into this! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants