-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Ember Simple Auth an Ember CLI addon only #519
Comments
+1 |
This would be great, I just noticed today that I was running an old version of simple-auth because I'd been updating the version in package.json but not in bower.json so it hadn't actually updated anything! |
🎆 that's great to hear, should simplify a few things on your side regarding maintainability |
I'd be happy to help if needed. |
@marcoow do you consider moving to the new initializers while doing this or should this be a seperate issue? |
Yes, this will also use instance initializers. |
Nice 👍 |
I think that all the efforts for maintaining a globals version should go directly to this addon: https://github.com/ef4/ember-giftwrap |
+1 |
see #602 |
With Ember CLI being the official standard way for building Ember applications it doesn't make sense anymore to keep the globalized and AMD distributions as that adds a lot of overhead and also makes it hard to install the library in Ember Cli applications from github directly. Instead for the 1.0 release the library should use the Ember CLI addon in the main repository which would also make it much simpler to include Acceptance Tests in the main repository.
The text was updated successfully, but these errors were encountered: