Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ember Simple Auth an Ember CLI addon only #519

Closed
marcoow opened this issue May 7, 2015 · 10 comments
Closed

Make Ember Simple Auth an Ember CLI addon only #519

marcoow opened this issue May 7, 2015 · 10 comments
Assignees
Milestone

Comments

@marcoow
Copy link
Member

marcoow commented May 7, 2015

With Ember CLI being the official standard way for building Ember applications it doesn't make sense anymore to keep the globalized and AMD distributions as that adds a lot of overhead and also makes it hard to install the library in Ember Cli applications from github directly. Instead for the 1.0 release the library should use the Ember CLI addon in the main repository which would also make it much simpler to include Acceptance Tests in the main repository.

@marcoow marcoow self-assigned this May 7, 2015
@marcoow marcoow added this to the 1.0 milestone May 7, 2015
@bradplank
Copy link

+1

@rlivsey
Copy link

rlivsey commented May 12, 2015

This would be great, I just noticed today that I was running an old version of simple-auth because I'd been updating the version in package.json but not in bower.json so it hadn't actually updated anything!

@jpadilla
Copy link

🎆 that's great to hear, should simplify a few things on your side regarding maintainability

@tzellman
Copy link

I'd be happy to help if needed.

@piotrpalek
Copy link

@marcoow do you consider moving to the new initializers while doing this or should this be a seperate issue?
see: http://emberjs.com/deprecations/v1.x/#toc_access-to-instances-in-initializers

@marcoow
Copy link
Member Author

marcoow commented Jun 5, 2015

Yes, this will also use instance initializers.

@piotrpalek
Copy link

Nice 👍

@miguelcobain
Copy link
Contributor

I think that all the efforts for maintaining a globals version should go directly to this addon: https://github.com/ef4/ember-giftwrap

@maysam-tayyeb
Copy link

+1

@marcoow
Copy link
Member Author

marcoow commented Oct 16, 2015

see #602

@marcoow marcoow closed this as completed Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants