Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdaptiveStore should use DI instead of initializing other stores by itself #2308

Closed
3 tasks
BobrImperator opened this issue Jun 11, 2021 · 0 comments · Fixed by #2312
Closed
3 tasks

AdaptiveStore should use DI instead of initializing other stores by itself #2308

BobrImperator opened this issue Jun 11, 2021 · 0 comments · Fixed by #2312
Assignees
@BobrImperator
Labels
internal

Comments

@BobrImperator
Copy link
Collaborator

It splits #2302
While working on #2306 we've discovered that store related tests are failing due to them not being isolated - after refactoring internals to use explicitly injected services and refactoring tests accordingly the tests would leak their instances to other tests in some cases e.g itBehavesLikeStore causes this to happen, this issue should make it easier to test AdaptiveStore

TODOS

  • register session-store:cookie session-store:local-storage
  • use registered session-stores in AdaptiveStore directly
  • refactor AdaptiveStore tests to use Ember DI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BobrImperator BobrImperator

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[2308] Refactor Adaptive store to use DI BobrImperator/ember-simple-auth
1 participant
@BobrImperator