Ember.SimpleAuth conflict with Ember.PersistenceFoundation on "session" injection

[ncoquelet]

Hi,

I start using Ember.SimpleAuth and it's an amazing library ! Well documented and very extensible.

On my projet, I also use Ember persistence foundation (EPF), but I am very bad problem.

Each use an injected object call "session" into the route ...

Do you have a idea to rename session object in SimpleAuth ?

Thanks

[marcoow]

Not sure whether Ember has a strategy for conflicting injections. Right now the only solution would be to fork one of the 2 libraries and rename the injected property in the entire codebases. Maybe you can get in contact with the core team and find out whether there's something planned to solve that or some suggested strategy for 3rd party injections in general?

[bakura10]

Hi,

As Ember-Simple auth is much smaller than EPF, maybe we could rename "session" to "auth-session". this would make it much easier also for other users (I've always found it confusing to have a name "session"). What do you think?

[marcoow]

Why do you find the name "session" to be confusing? Because that's what Ember.SimpleAuth's session actually is (by being a replacement for a server side session which doesn't exist in Ember apps). I don't think renaming is not really a good idea - I'd rather come up with a short guide on how to rename it manually if there's a conflict (resolving the conflict with EPF doesn't mean the next conflict couldn't come up soon thereafter).

[bakura10]

The fact that it's using a common English name ("session") will without doubt causes more and more conflicts in the future. Having a short guide about how to rename is not a solution I think. If you need to rename all your injections before starting a project, that's going to be a whole mess.

The solution is easy: just reducing the chance for conflict to appear by using more targeted name. So EPF should maybe use "data-session", Ember-Simple Auth "auth-session". This way the name is "kind of" namespaced, and there is really few chance to encounter another "auth-session" (because you likely don't use two auth libraries altogether).

[ncoquelet]

Hi,

Last week, after create this issue, I have try to rename simpleAuth session object with success. (This is much easier than rename epf stuff)

So, I changed the container registration name to "sessionAuth:main" and the inject field to "sessionAuth", both are in conflict with epf.

I have commited in a fork at https://github.com/ncoquelet/ember-simple-auth

[ncoquelet]

@bakura10 I have read somewhere, that ember have injection conflict solution, but as ember beginner i don't know all ember possibilities.

Otherwise, epf team suggest that maybe could be resolved by runtime configuration ...
getoutreach/epf#127

thanks both of you
open to all others suggestions

[marcoow]

I added a "namespace" to the names that Ember.SimpleAuth registers its components with and made the name of the session property configurable: f2d94a8

[ncoquelet]

Work nice
Thanks ;)