Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.1 deprecation warning #215

Closed
lubosch opened this issue Jan 21, 2021 · 3 comments
Closed

Rails 6.1 deprecation warning #215

lubosch opened this issue Jan 21, 2021 · 3 comments

Comments

@lubosch
Copy link

lubosch commented Jan 21, 2021

this issue: rails/rails#36546 is caused by this gem because of

# /lib/railgun/railtie.rb
ActionMailer::Base.add_delivery_method :mailgun, Railgun::Mailer

rails/rails#36546 (comment)

and it can be fixed I guess by rails/rails#36546 (comment)

ActiveSupport.on_load(:action_mailer) do
  add_delivery_method :mailgun, Railgun::Mailer
end
@cgunther
Copy link

cgunther commented Feb 3, 2021

#162 is an attempt to address this.

@lubosch
Copy link
Author

lubosch commented Feb 10, 2021

official response from mailgun support:

We do not have an exact date as this is something that is being worked on. Our goal is to have it done in roughly the next few months

So either don't use mailgun, this gem, fix it yourself or don't upgrade rails next few months ...

@zokioki
Copy link

zokioki commented Apr 5, 2021

Looks like a fix for this was just introduced in v1.2.4:
https://github.com/mailgun/mailgun-ruby/blob/v1.2.4/lib/railgun/railtie.rb#L5-L8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants