Skip to content
This repository has been archived by the owner on Jun 25, 2021. It is now read-only.

Use of unstable features #560

Closed
Fraser999 opened this issue Aug 7, 2015 · 3 comments
Closed

Use of unstable features #560

Fraser999 opened this issue Aug 7, 2015 · 3 comments

Comments

@Fraser999
Copy link
Contributor

The following feature gates are being used (which disallow this to be built on the Beta or Stable Rust channels):

#![feature(convert, core)]
#![feature(convert)]

@benjaminbollen benjaminbollen self-assigned this Aug 7, 2015
@benjaminbollen
Copy link

we use convert in src/error.rs, but that usage is stable now
we don't use core, so that is easily removed,
the remaining unstable use of convert is in NameType::get_full_id() but we never use that; so I can simply remove remove get_full_id, or we can find a better way to append strings

@benjaminbollen
Copy link

the story is a bit more involved. I was too quick to think that #[feature(core)] could be dropped from the example (refer to failed #561).

Also removing "get_full_id" from NameType is trivial, as it is unused; but the unit tests for debug_output of the NameType does use the get_full_id to check the correctness of the debug output.

This needs a better was of unit testing the NameType debug output. Can not be a blocker, but might be a bit more hairy.

@benjaminbollen
Copy link

almost resolved by latest work in example. Only the nametype tests use an unstable feature for a secondary way of testing the debug representation of NameType; the test need to be rewritten without the unstable feature

@dirvine dirvine assigned ghost and unassigned benjaminbollen Aug 26, 2015
@ghost ghost closed this as completed in 1a60a20 Aug 26, 2015
benjaminbollen pushed a commit that referenced this issue Aug 26, 2015
Remove unstable feature. Fixes #560.
maqi pushed a commit to maqi/routing that referenced this issue Nov 14, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants