This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
interface test #11
Merged
interface test #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @canndrew (maidsafe_highfive has picked a reviewer for you, use r? to override) |
| @@ -537,12 +537,20 @@ pub fn get_if_addrs() -> io::Result<Vec<Interface>> { | |||
| #[cfg(test)] | |||
| mod test { | |||
| use super::get_if_addrs; | |||
| use ip::IpAddr; | |||
| use std::net::Ipv4Addr; | |||
|
|
|||
| #[test] | |||
| fn test_get_if_addrs() { | |||
| let ifaces = get_if_addrs().unwrap(); | |||
There was a problem hiding this comment.
This should be perhaps 2 tests, on for local_addr == 1 and another that compares what the OS believes is ifaddrs with what we believe, i.e. compare parsed output of ipconfig with our output or use /proc filesystem to get the interface addresses
|
This works on Linux but I haven't been able to test it on windows due to a compiler ICE. I'll trust @maqi and AppVeyor that it's working there aswell. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.