Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use rustfmt options? #164

Closed
Saethox opened this issue Apr 4, 2023 · 1 comment
Closed

Should we use rustfmt options? #164

Saethox opened this issue Apr 4, 2023 · 1 comment
Labels
discussion There is some decision that can not be made alone

Comments

@Saethox
Copy link
Collaborator

Saethox commented Apr 4, 2023

Especially our imports are kind of all over the place, so I'd like some automated solution. The imports_granularity = "Crate" and group_imports = "StdExternalCrate" (https://rust-lang.github.io/rustfmt/?version=v1.5.2&search=imports) look like a good starting point, in my opinion. The only downside to this is that both options require nightly rustfmt, but that may be fine. Only rustfmt needs nightly after all, not the build in general.
@Saethox Saethox added the discussion There is some decision that can not be made alone label Apr 4, 2023
@Saethox Saethox mentioned this issue Jun 5, 2023
Closed
@Saethox
Copy link
Collaborator Author

Saethox commented Jul 6, 2023

Resolved with #180.

@Saethox Saethox closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion There is some decision that can not be made alone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Saethox