Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use structs in smart contracts #37

Closed
andrewgordstewart opened this issue Nov 4, 2018 · 1 comment
Closed

Use structs in smart contracts #37

andrewgordstewart opened this issue Nov 4, 2018 · 1 comment

Comments

@andrewgordstewart
Copy link
Contributor

The ABIEncoderV2 allows us to use solidity structs as inputs/outputs of external functions.

Switching to structs would:

  • simplify the codebase
  • lower the barrier of entry for developers who aren't Solidity experts
  • make defining complex rules much more tractable

Problems

  • P1: web3 contracts do not work with smart contract functions that return or accept structs
@andrewgordstewart
Copy link
Contributor Author

andrewgordstewart commented Nov 4, 2018 •
edited
Loading

P1 solutions

S1

Switch to ethers.js contracts, which support the ABIEncoderV2

S2

Upgrade truffle's web3 dependencies

@andrewgordstewart andrewgordstewart mentioned this issue Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewgordstewart