Skip to content
This repository has been archived by the owner on Oct 26, 2020. It is now read-only.

NotSupportedException #142

Closed
Kerbas-ad-astra opened this issue Oct 22, 2016 · 3 comments
Closed

NotSupportedException #142

Kerbas-ad-astra opened this issue Oct 22, 2016 · 3 comments

Comments

@Kerbas-ad-astra
Copy link
Contributor

Changes in Contract Configurator 1.20 mean that certain reflection methods will cause NotSupportedExceptions -- see blizzy78/ksp_toolbar#39 for more details. I can give you a PR that fixes all of the reflection calls presently in KCT (to the toolbar, Kerbal Alarm Clock, Stage Recovery...), if you haven't rewritten too much of KCT yet.

@magico13
Copy link
Owner

Shouldn't that just require updating ToolbarWrapper.cs? If so, that should be pretty straightforward for me to update while I work on getting everything else up to date.

@Kerbas-ad-astra
Copy link
Contributor Author

Kerbas-ad-astra commented Oct 22, 2016

Not just ToolbarWrapper, but CrewQAPI, KACWrapper, KCT_Events (for RealChutes), KCT_Utilities (for StageRecovery), MCEWrapper, and StageRecoveryWrapper -- anything that uses that pattern of "AssemblyLoader.loadedAssemblies.SelectMany..." needs to be changed to the TypeOperation pattern. (Maybe I should make a PR.)

@Kerbas-ad-astra
Copy link
Contributor Author

Resolved by accepted PR #143.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants