From 7f864ddb3474f305a090a853c7aa97e2398ecbd1 Mon Sep 17 00:00:00 2001 From: Sam Marcus Date: Wed, 13 Apr 2016 03:51:35 -0400 Subject: [PATCH 1/2] Added call to action to compile command error The original informational message stated the situation but did not suggest how to resolve it. By suggesting how to rectify the situation, it is far more useful than sending the user on a goose chase. --- setup/src/Magento/Setup/Console/Command/UpgradeCommand.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php index 44064e4b9409f..b5a15bc87ee0f 100644 --- a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php +++ b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php @@ -71,7 +71,7 @@ protected function execute(InputInterface $input, OutputInterface $output) $installer->installSchema(); $installer->installDataFixtures(); if (!$keepGenerated) { - $output->writeln('Please re-run Magento compile command'); + $output->writeln('Please re-run Magento compile command. This may be done with setup:di:compile'); } } } From f21db1a0c8ba26480faf9c3c9a5f7fc166504f10 Mon Sep 17 00:00:00 2001 From: Sam Marcus Date: Tue, 18 Oct 2016 15:54:59 -0500 Subject: [PATCH 2/2] Shorted text because longer string failed CI build --- setup/src/Magento/Setup/Console/Command/UpgradeCommand.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php index 0729ebdc2733f..be44fa903e599 100644 --- a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php +++ b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php @@ -71,7 +71,7 @@ protected function execute(InputInterface $input, OutputInterface $output) $installer->installSchema(); $installer->installDataFixtures(); if (!$keepGenerated) { - $output->writeln('Please re-run Magento compile command. This may be done with setup:di:compile'); + $output->writeln('Please re-run Magento compile command. Use setup:di:compile'); } return \Magento\Framework\Console\Cli::RETURN_SUCCESS;