Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid comment for the method __order in Magento\Sales\Model\Order\Payment.php #7860

Closed
denchev opened this issue Dec 17, 2016 · 2 comments
Closed

Invalid comment for the method __order in Magento\Sales\Model\Order\Payment.php #7860

denchev opened this issue Dec 17, 2016 · 2 comments
Assignees
@mcspronko
Labels
bug report Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@denchev
Copy link
Contributor

denchev commented Dec 17, 2016 •
edited
Loading

Preconditions

Does not apply

Steps to reproduce

  1. Open Magento\Sales\Model\Order\Payment.php (Line 1040)
  2. Locate method _order
  3. Look at the comment

Expected result

  1. Expect to see a proper comment what this method does

Actual result

  1. The comment seems to be cut off "* Order payment either online" and does not continue with the rest of the sentence
  2. I think it is just a copy/paste from the authorize method while these two methods (may) differ in functionality.
@olysenko olysenko self-assigned this Dec 21, 2016
@olysenko
Copy link

Hi, thank you for your report. Internal issue MAGETWO-62509 was created

@olysenko olysenko removed their assignment Dec 21, 2016
@olysenko olysenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop and removed in progress labels Dec 21, 2016
@okorshenko okorshenko mentioned this issue Mar 3, 2017
Merged
@ishakhsuvarov
Copy link
Contributor

@denchev The issue has now been fixed with the PR #8769
Thank you for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcspronko mcspronko

Labels
bug report Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@denchev @veloraven @mcspronko @ishakhsuvarov @okorshenko @olysenko