[Issue] Prevent side effect on category objects store_id and url_key on save

[m2-assistant]

This issue is automatically created based on existing pull request: #28164: Prevent side effect on category objects store_id and url_key on save

---

Preconditions (*)

Magento 2.4-develop

Category URL rewrites are saved by an "after save" observer for categories. But if saved for global scope, the URL rewrite generator itself modifies the passed category object for each assigned store to generate URL rewrites for all stores. Afterwards, url_key, url_path and store_id have the values of the last processed store id. This has side effects on later observers or other code that works on the category object after saving it.

Since the default store (0) is always the first item of $category->getStoreIds() I chose to clone the category object only for the other stores, so that url_key and url_path for the global scope are still set to the original object.

Related Pull Requests

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Steps to reproduce (*)

Abbreviated test case

$category->setStoreId(0);
$category->setUrlKey('url-key-for-global-scope');
$categoryResource->save($category);

Expected result (*)

$category->getStoreId() should return 0

Actual result (*)

$category->getStoreId() returns value of the last processed store id.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-37815 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gabrieldagama]

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #28164 by @schmengler in 2.4-develop branch
Related commit(s):

• 7bd5e25d290bf905fbf8254b66bedae01a5c6717
• 8bcd2fa8839cd3f0fb659d49ee1590b664b9687c
• 87c5c609769388433a127ca0999addb4cb841691
• 31c5963f8e21008e799598fc34b26e0728ba56f0
• c051134a4b2c837f798cc8f66b9ad4c208310363
• 6083a7cb6ee174801684a8420d2212d51315009a

The fix will be available with the upcoming 2.4.2 release.