Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some space between input and update button Minicart #26227

Closed
hitesh-wagento opened this issue Jan 2, 2020 · 7 comments
Closed

Need some space between input and update button Minicart #26227

hitesh-wagento opened this issue Jan 2, 2020 · 7 comments
Assignees
Labels
Area: Design/Frontend Area: Frontend Component: Checkout Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue

Comments

@hitesh-wagento
Copy link
Contributor

hitesh-wagento commented Jan 2, 2020

Summary

Need some space between input and update button in Minicart

Preconditions

  1. Magento 2x - This issue reproduce in all version.

Steps to reproduce

  1. Add any product in cart
  2. Click on input in Minicart
  3. Add Qty you will see the update button

Expected result

  1. Need some space between input and update button in Minicart like in mobile view.
    expected

Actual result

  1. No space between input and update button in Minicart
    actual
@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @hitesh-wagento. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@hitesh-wagento do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 2, 2020
@hitesh-wagento hitesh-wagento added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Area: Design/Frontend Area: Frontend Component: Checkout Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jan 2, 2020
@hitesh-wagento hitesh-wagento self-assigned this Jan 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @hitesh-wagento. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@krishprakash krishprakash self-assigned this Jan 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@hitesh-wagento
Copy link
Contributor Author

I am working on this issue

@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @dmytro-ch. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@dmytro-ch dmytro-ch removed the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Jan 2, 2020
@dmytro-ch
Copy link
Contributor

dmytro-ch commented Jan 2, 2020

Hello @hitesh-wagento, the minor improvements do not require a separate issue to be created.
Feel free to create a PR only.
Thank you!

@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 8, 2020
@VladimirZaets
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your report.
The issue has been fixed in #26234 by @hitesh-wagento in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Component: Checkout Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue
Projects
None yet
Development

No branches or pull requests

7 participants