Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Minimum Qty Allowed in Shopping Cart" functionality breaks product "Update Attributes" functionality #21640

Closed
samgranger opened this issue Mar 8, 2019 · 22 comments
Assignees
Labels
Component: CatalogInventory Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@samgranger
Copy link
Contributor

samgranger commented Mar 8, 2019

Preconditions (*)

  1. Magento 2.2.7 / 2.3.0

Steps to reproduce (*)

  1. Check the value of cataloginventory/item_options/min_sale_qty, the default value is 1.
  2. Go to: Stores -> Configuration -> Catalog -> Inventory
  3. Make sure there are multiple or no rules for 'Minimum Qty Allowed in Shopping Cart' & save your configuration.
  4. You'll now see that cataloginventory/item_options/min_sale_qty gets an array as a value.
  5. Go to: Catalog -> Products
  6. Select one or more products and click on Update Attributes in the Actions dropdown menu.

Expected result (*)

  1. The ability to do a Mass Update of attributes for the selected product(s).

Actual result (*)

  1. No form visible
  2. Our system.log reports the following issue:
main.CRITICAL: Warning: A non-numeric value encountered in vendor/magento/module-catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml on line 135

This is because cataloginventory/item_options/min_sale_qty is no longer a numeric value.

screen shot 2019-03-08 at 09 50 51

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 8, 2019

Hi @samgranger. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@samgranger do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@samgranger samgranger changed the title Having multiple or no rules for "Minimum Qty Allowed in Shopping Cart" breaks Product Mass Update Having multiple or no rules for "Minimum Qty Allowed in Shopping Cart" breaks Product Update Attributes functionality Mar 8, 2019
@samgranger samgranger changed the title Having multiple or no rules for "Minimum Qty Allowed in Shopping Cart" breaks Product Update Attributes functionality "Minimum Qty Allowed in Shopping Cart" functionality breaks product "Update Attributes" functionality Mar 8, 2019
@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: https://i-21640-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hiren0241
Copy link
Contributor

Hi @samgranger, By following steps to reproduce, I am unable to reproduce it.

@samgranger
Copy link
Contributor Author

@hiren0241 I noticed the setting wasn't changed, see screenshot. I have changed this for you. Please try the Update Attributes functionality again.
screen shot 2019-03-08 at 10 31 39

screen shot 2019-03-08 at 10 35 50

screen shot 2019-03-08 at 10 35 38

@hiren0241
Copy link
Contributor

@samgranger Okay, got your point. Let me try once again.

@hiren0241
Copy link
Contributor

@samgranger Reproduced. Thanks for correction.

@hiren0241 hiren0241 self-assigned this Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 8, 2019

Hi @hiren0241. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@hiren0241 hiren0241 added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: CatalogInventory Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @hiren0241
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 8, 2019
@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: https://i-21640-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hiren0241 hiren0241 added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Mar 8, 2019
@hiren0241 hiren0241 self-assigned this Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 8, 2019

Hi @hiren0241. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@hiren0241
Copy link
Contributor

@samgranger
Issue confirmed: https://prnt.sc/mv00le
Presently, I am working on this issue.

@shikhamis11 shikhamis11 self-assigned this Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 8, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@samgranger
Copy link
Contributor Author

Great, thank you @hiren0241

@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98627, MAGETWO-98628 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@hiren0241
Copy link
Contributor

hiren0241 commented Mar 8, 2019

@samgranger While getting configuration from database , this value: '{"32000":456,"0":123}' creates an error. we need to unserialize the config value.
I case of default value, nothing is happen. But, while we not using default system config it gives an error.

@samgranger
Copy link
Contributor Author

samgranger commented Mar 8, 2019

@hiren0241 Indeed, I believe this use to be a fixed integer value configuration but now it can vary per user group. You'd expect the default value would also be an object now instead of just being 1.

@hiren0241
Copy link
Contributor

@samgranger I have fixed issue by getting exact configuration value set by back-end configuration. Now, whatever sets in back-end same will reflect in frontend as well.

@dmytro-ch
Copy link
Contributor

Hi @samgranger,
thank you for your report!

This bug has been already reported in #17592.
So I'm closing the current issue in order to avoid duplicates.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogInventory Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants