Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared dynamic property gets leaked in public space #2103

Closed
adragus-inviqa opened this issue Oct 13, 2015 · 4 comments
Closed

Undeclared dynamic property gets leaked in public space #2103

adragus-inviqa opened this issue Oct 13, 2015 · 4 comments
Assignees
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@adragus-inviqa
Copy link
Contributor

I'm talking about this:

$this->renderer = $this->getChildBlock('renderer');

There is no \Magento\LayeredNavigation\Block\Navigation::$renderer member, so it becomes public.

@piotrekkaminski
Copy link
Contributor

@antonkril can you look into this and decide on priority?

@antonkril
Copy link
Contributor

It's low priority, but we should create static test to catch such cases. They allow unreliable implementations of extensions and make instantiation of such classes bit slower.

@voleye
Copy link

voleye commented Jan 19, 2016

I have created an internal ticket (MAGETWO-48089) to track the progress of the issue

@vkholoshenko vkholoshenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 20, 2016
@KrystynaKabannyk
Copy link

Hello @adragus-inviqa, this issue has been fixed in the 2.1.0 Release, that's why I'm closing it. If you any questions or additional information regarding the issue feel free to reopen it or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants