Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magento_Tax "postcode is a required field" when upgrading from 2.1.9 to 2.2 #11095

Closed
friimaind opened this issue Sep 27, 2017 · 17 comments
Closed

Magento_Tax "postcode is a required field" when upgrading from 2.1.9 to 2.2 #11095

friimaind opened this issue Sep 27, 2017 · 17 comments
Assignees
@lewisvoncken
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release

Comments

@friimaind
Copy link

Preconditions

Magento 2.1.9 CE
PHP 7.0.22-0ubuntu0.17.04.1
MySQL 5.7.19-0ubuntu0.17.04.1

Steps to reproduce

Upgrade Magento 2.1.9 to 2.2 CE with composer

composer require magento/product-community-edition 2.2 --no-update
composer update
php -f bin/magento setup:upgrade

Expected result

Magento 2.2 updated

Actual result

php -f bin/magento setup:upgrade returns:

...
Module 'Magento_Swatches':
Module 'Magento_SwatchesLayeredNavigation':
Module 'Magento_Tax':
Upgrading data.. postcode is a required field.
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Sep 27, 2017
@magento-engcom-team
Copy link
Contributor

@friimaind, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue.

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Sep 28, 2017
@rmendoza3
Copy link

I am having the same issue. I am also trying to upgrade from 2.1.9 to 2.2.0. I run into a "postcode is a required field." error and the setup:upgrade dies. If I find anything out I will be sure to update it here.

@kervin
Copy link

kervin commented Sep 29, 2017

Same issue. @magento-engcom-team, create a tax rule without postcode first, then setup:upgrade.. seems obvious.

Test properly before saying "Can not reproduce"!

@JoostWan
Copy link

Same issue here. To fix this check the table tax_calculation_rate. When the field tax_postcode is empty enter a *

Then the upgrade will work.

@friimaind
Copy link
Author

Thanks @JoostWan , according to my database this query fixed the issue:

UPDATE tax_calculation_rate SET tax_postcode = '*' WHERE tax_postcode IS NULL

@jwohlfeil
Copy link

Same Problem here, JoostWan's and friimaind's tipps fixed it.

@lewisvoncken
Copy link
Contributor

@magento-engcom-team
I can reproduce the issue and it is only when you have existing rules with tax_postcode NULL. Maybe I will provide a fix for this issue.

@lewisvoncken lewisvoncken mentioned this issue Oct 23, 2017
Merged
4 tasks
@lewisvoncken
Copy link
Contributor

@friimaind I supplied a pull request for this issue.

@lewisvoncken
Copy link
Contributor

I'm working on it #SQUASHTOBERFEST

@orlangur orlangur reopened this Oct 24, 2017
@orlangur orlangur removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Oct 24, 2017
@orlangur orlangur assigned orlangur and lewisvoncken and unassigned orlangur Oct 24, 2017
@lewisvoncken lewisvoncken mentioned this issue Oct 25, 2017
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Oct 27, 2017
@magento-engcom-team
Copy link
Contributor

@friimaind, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue.

@orlangur
Copy link
Contributor

@magento-engcom-team did you try steps from #11735? So basically you need to set null manually to mentioned field in database to recreate circumstances of bug report.

@orlangur
Copy link
Contributor

@lewisvoncken I don't see this issue was ever eligible for #SQUASHTOBERFEST

@TomashKhamlai
Copy link
Contributor

Reproduced

@TomashKhamlai TomashKhamlai reopened this Oct 30, 2017
@TomashKhamlai TomashKhamlai removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Oct 30, 2017
@lewisvoncken
Copy link
Contributor

@TomashKhamlai I also could reproduce and I have provided a fix in pull request #11735

@magento-team magento-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82595

@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch. Will be available in 2.2.2 release

@magento-engcom-team
Copy link
Contributor

@friimaind, thank you for your report.
The issue is already fixed in 2.2.2

@magento-engcom-team magento-engcom-team added 2.1.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewisvoncken lewisvoncken

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests