Magento 2 Loading custom option dropdown issue

[NagarajuKasa]

Preconditions

1. Magento 2.1

Steps to reproduce

1. Log in to admin
2. Go to Catalog -> Products and start to create new product
3. Add Customizable Options with next steps:
   • Select Drop-down Option Type.
   • Click the 'Add value' button to add an empty row, leave it empty.
   • Select a different Option Type (doesn't matter which).
   • Select 'Drop-down' Option Type again.

Expected Result

The option Drop-down is selected and values are possible to edit

Actual Result

The option Drop-down is selected and a infinite loader is presented

Description

Hi,
We are facing the issue with default magento2.17
#issue:
While selecting the OptionType select fields for second time its loadind continuosly.

Please find the steps in the screenshot:
https://prnt.sc/fwkrc5

Thanks

[SanderJP]

I can reproduce this on a clean 2.1.7 installation with these steps:

1. Create or edit a Simple product.
2. Add Custom option.
3. Select 'Drop-down' Option Type.
4. Click the 'Add value' button to add an empty row, leave it empty.
5. Select a different Option Type (doesn't matter which).
6. Select 'Drop-down' Option Type again.

Result is a infinite loader and no javascript error message.

[RomanKrut]

@NagarajuKasa Hi, thanks for your feedback. The internal ticket was created MAGETWO-70954 to address this issue.

[NagarajuKasa]

thanks for reply i hope you will fix in the coming version.... thanks

[NagarajuKasa]

is there any update on this ticket?

[magento-engcom-team]

@NagarajuKasa, thank you for your report.
We've created internal ticket(s) MAGETWO-70954 to track progress on the issue.

[briscoda]

I would like to work on this one, can you assign it to me? #squashtoberfest

[okorshenko]

@briscoda please accept the invite

[briscoda]

The problem here can be traced back to this file:

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js#L610

In cases where there are option values added for the "Select" option types, the javascript will try to keep track of those options if they are not deleted by clicking on the trash can icon.

When the user toggles back to the select option, it then tries to do some logical not operation that seems to fail because the previous options don't seem to get properly deleted from the recordData.

I cannot think of a case in my testing where you would ever want the spinner to show up for these custom options.

The solution might be to either make sure that the "recordData" gets updated correctly so that records don't linger, or to remove the spinner functionality from this altogether. I tried looking back through commit history to see what the reason was for adding in spinner functionality there, but couldn't really tell from looking at it.

One thing that I think will happen if you make the recordData remove those entries, will be that one existing products with custom options, you could potentially lose any custom options that were set.

@okorshenko Who would be the right person to advise on a potential solution?

[magento-team]

Internal ticket to track issue progress: MAGETWO-82943

[okorshenko]

the issue has been fixed and delivered to 2.2-develop branch. WIll be available with 2.2.2 release

[magento-engcom-team]

Hi @NagarajuKasa. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1285 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• ad6c0af
• 6d3d70a
• 6b0c02c
• c8abb13
• c6a9b5f
• c867b81
• 88a3ad0
• d87e316
• c76b04c
• 5ae2109
• 931133a
• 4c927a0
• 060a8f9
• 4da2a7d
• 008ef55
• d3642e8
• d37ce08
• b22b232
• 6c02a2d
• f2ec2ea

The fix will be available with the upcoming patch release.

[NagarajuKasa]

Thank you so much for updating.
Great job.