From 179b85415038d327b29e6e2f390d7e35820ed5d8 Mon Sep 17 00:00:00 2001 From: pawankparmar Date: Sat, 14 Dec 2019 22:31:04 +0530 Subject: [PATCH 1/6] spelling fix and put space --- .../Api/Data/ProductRender/FormattedPriceInfoInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php index 43e0de4f20176..65ff84ef719f0 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php @@ -66,7 +66,7 @@ public function getMinimalPrice(); /** * Set max regular price - * Max regular price is the same, as maximum price, except of excluding calculating special price and catalogules + * Max regular price is the same, as maximum price, except of excluding calculating special price and catalog rules * in it * * @param string $maxRegularPrice From 3fdf545e50e97eead23b184574beccb34ccbc49a Mon Sep 17 00:00:00 2001 From: pawankparmar Date: Mon, 16 Dec 2019 09:39:13 +0530 Subject: [PATCH 2/6] fix static test change --- .../Api/Data/ProductRender/FormattedPriceInfoInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php index 65ff84ef719f0..a79033035ca22 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php @@ -164,4 +164,4 @@ public function getExtensionAttributes(); public function setExtensionAttributes( \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes ); -} +} \ No newline at end of file From 1d63932dadfaa6c604b599f28fbc3a4278fb9443 Mon Sep 17 00:00:00 2001 From: pawankparmar Date: Mon, 16 Dec 2019 10:13:18 +0530 Subject: [PATCH 3/6] fix static test change with phpcbf --- .../FormattedPriceInfoInterface.php | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php index a79033035ca22..5f192dcd98a17 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php @@ -23,7 +23,7 @@ interface FormattedPriceInfoInterface extends \Magento\Framework\Api\ExtensibleD * Retrieve html with final price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getFinalPrice(); @@ -31,9 +31,9 @@ public function getFinalPrice(); * Set the final price: usually it calculated as minimal price of the product * Can be different depends on type of product * - * @param string $finalPrice + * @param string $finalPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setFinalPrice($finalPrice); @@ -42,16 +42,16 @@ public function setFinalPrice($finalPrice); * E.g. for product with custom options is price with the most expensive custom option * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMaxPrice(); /** * Set the max price of the product * - * @param string $maxPrice + * @param string $maxPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMaxPrice($maxPrice); @@ -60,7 +60,7 @@ public function setMaxPrice($maxPrice); * The minimal price is for example, the lowest price of all variations for complex product * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMinimalPrice(); @@ -69,9 +69,9 @@ public function getMinimalPrice(); * Max regular price is the same, as maximum price, except of excluding calculating special price and catalog rules * in it * - * @param string $maxRegularPrice + * @param string $maxRegularPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMaxRegularPrice($maxRegularPrice); @@ -79,16 +79,16 @@ public function setMaxRegularPrice($maxRegularPrice); * Retrieve max regular price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMaxRegularPrice(); /** * The minimal regular price has the same behavior of calculation as max regular price, but is opposite price * - * @param string $minRegularPrice + * @param string $minRegularPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMinimalRegularPrice($minRegularPrice); @@ -96,7 +96,7 @@ public function setMinimalRegularPrice($minRegularPrice); * Retrieve minimal regular price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMinimalRegularPrice(); @@ -105,9 +105,9 @@ public function getMinimalRegularPrice(); * * Special price - is temporary price, that can be set to specific product * - * @param string $specialPrice + * @param string $specialPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setSpecialPrice($specialPrice); @@ -115,16 +115,16 @@ public function setSpecialPrice($specialPrice); * Retrieve special price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getSpecialPrice(); /** * Set minimal price * - * @param string $minimalPrice + * @param string $minimalPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMinimalPrice($minimalPrice); @@ -133,16 +133,16 @@ public function setMinimalPrice($minimalPrice); * Usually this price is corresponding to price in admin panel of product * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getRegularPrice(); /** * Set regular price * - * @param string $regularPrice + * @param string $regularPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setRegularPrice($regularPrice); @@ -150,16 +150,16 @@ public function setRegularPrice($regularPrice); * Retrieve existing extension attributes object or create a new one. * * @return \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface|null - * @since 101.1.0 + * @since 101.1.0 */ public function getExtensionAttributes(); /** * Set an extension attributes object. * - * @param \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes + * @param \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes * @return $this - * @since 101.1.0 + * @since 101.1.0 */ public function setExtensionAttributes( \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes From b92c9aacc8d2ff658c197bbbcb924c8fb16f9fd3 Mon Sep 17 00:00:00 2001 From: pawankparmar Date: Wed, 18 Dec 2019 10:42:28 +0530 Subject: [PATCH 4/6] Remove extra spaces --- .../FormattedPriceInfoInterface.php | 50 +++++++++---------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php index 5f192dcd98a17..65ff84ef719f0 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php @@ -23,7 +23,7 @@ interface FormattedPriceInfoInterface extends \Magento\Framework\Api\ExtensibleD * Retrieve html with final price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getFinalPrice(); @@ -31,9 +31,9 @@ public function getFinalPrice(); * Set the final price: usually it calculated as minimal price of the product * Can be different depends on type of product * - * @param string $finalPrice + * @param string $finalPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setFinalPrice($finalPrice); @@ -42,16 +42,16 @@ public function setFinalPrice($finalPrice); * E.g. for product with custom options is price with the most expensive custom option * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMaxPrice(); /** * Set the max price of the product * - * @param string $maxPrice + * @param string $maxPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMaxPrice($maxPrice); @@ -60,7 +60,7 @@ public function setMaxPrice($maxPrice); * The minimal price is for example, the lowest price of all variations for complex product * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMinimalPrice(); @@ -69,9 +69,9 @@ public function getMinimalPrice(); * Max regular price is the same, as maximum price, except of excluding calculating special price and catalog rules * in it * - * @param string $maxRegularPrice + * @param string $maxRegularPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMaxRegularPrice($maxRegularPrice); @@ -79,16 +79,16 @@ public function setMaxRegularPrice($maxRegularPrice); * Retrieve max regular price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMaxRegularPrice(); /** * The minimal regular price has the same behavior of calculation as max regular price, but is opposite price * - * @param string $minRegularPrice + * @param string $minRegularPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMinimalRegularPrice($minRegularPrice); @@ -96,7 +96,7 @@ public function setMinimalRegularPrice($minRegularPrice); * Retrieve minimal regular price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getMinimalRegularPrice(); @@ -105,9 +105,9 @@ public function getMinimalRegularPrice(); * * Special price - is temporary price, that can be set to specific product * - * @param string $specialPrice + * @param string $specialPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setSpecialPrice($specialPrice); @@ -115,16 +115,16 @@ public function setSpecialPrice($specialPrice); * Retrieve special price * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getSpecialPrice(); /** * Set minimal price * - * @param string $minimalPrice + * @param string $minimalPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setMinimalPrice($minimalPrice); @@ -133,16 +133,16 @@ public function setMinimalPrice($minimalPrice); * Usually this price is corresponding to price in admin panel of product * * @return string - * @since 101.1.0 + * @since 101.1.0 */ public function getRegularPrice(); /** * Set regular price * - * @param string $regularPrice + * @param string $regularPrice * @return void - * @since 101.1.0 + * @since 101.1.0 */ public function setRegularPrice($regularPrice); @@ -150,18 +150,18 @@ public function setRegularPrice($regularPrice); * Retrieve existing extension attributes object or create a new one. * * @return \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface|null - * @since 101.1.0 + * @since 101.1.0 */ public function getExtensionAttributes(); /** * Set an extension attributes object. * - * @param \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes + * @param \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes * @return $this - * @since 101.1.0 + * @since 101.1.0 */ public function setExtensionAttributes( \Magento\Catalog\Api\Data\ProductRender\FormattedPriceInfoExtensionInterface $extensionAttributes ); -} \ No newline at end of file +} From 80398d0386391c0d5f626c3dc9f774fecf6c6b98 Mon Sep 17 00:00:00 2001 From: pawankparmar Date: Tue, 24 Dec 2019 10:44:54 +0530 Subject: [PATCH 5/6] Adjust space b/w Short and Long Description --- .../Api/Data/ProductRender/FormattedPriceInfoInterface.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php index 65ff84ef719f0..abcc4bfe4ede2 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php @@ -29,6 +29,7 @@ public function getFinalPrice(); /** * Set the final price: usually it calculated as minimal price of the product + * * Can be different depends on type of product * * @param string $finalPrice @@ -39,6 +40,7 @@ public function setFinalPrice($finalPrice); /** * Retrieve max price of a product + * * E.g. for product with custom options is price with the most expensive custom option * * @return string @@ -57,6 +59,7 @@ public function setMaxPrice($maxPrice); /** * Retrieve the minimal price of the product or variation + * * The minimal price is for example, the lowest price of all variations for complex product * * @return string @@ -130,6 +133,7 @@ public function setMinimalPrice($minimalPrice); /** * Regular price - is price of product without discounts and special price with taxes and fixed product tax + * * Usually this price is corresponding to price in admin panel of product * * @return string From f49510b06beda972ae031a2a53764ff9cd14592d Mon Sep 17 00:00:00 2001 From: pawankparmar Date: Tue, 24 Dec 2019 11:49:02 +0530 Subject: [PATCH 6/6] Remove Whitespace --- .../Data/ProductRender/FormattedPriceInfoInterface.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php index abcc4bfe4ede2..d111de1b04b94 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductRender/FormattedPriceInfoInterface.php @@ -29,7 +29,7 @@ public function getFinalPrice(); /** * Set the final price: usually it calculated as minimal price of the product - * + * * Can be different depends on type of product * * @param string $finalPrice @@ -40,7 +40,7 @@ public function setFinalPrice($finalPrice); /** * Retrieve max price of a product - * + * * E.g. for product with custom options is price with the most expensive custom option * * @return string @@ -59,7 +59,7 @@ public function setMaxPrice($maxPrice); /** * Retrieve the minimal price of the product or variation - * + * * The minimal price is for example, the lowest price of all variations for complex product * * @return string @@ -133,7 +133,7 @@ public function setMinimalPrice($minimalPrice); /** * Regular price - is price of product without discounts and special price with taxes and fixed product tax - * + * * Usually this price is corresponding to price in admin panel of product * * @return string