diff --git a/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml b/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml index 84947051e798b..70a9239af5805 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml @@ -20,6 +20,7 @@
getHeaderText() ?>
+
getChildHtml('wysiwyg_images.uploader') ?>
diff --git a/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml b/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml index 2ee12c1be3b51..24482f1fb4209 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml @@ -69,10 +69,16 @@ require([ }, done: function (e, data) { var progressSelector = '#' + data.fileId + ' .progressbar-container .progressbar'; + var tempErrorMessage = document.createElement("div"); $(progressSelector).css('width', '100%'); + $('[data-action="show-error"]').children(".message").remove(); if (data.result && !data.result.hasOwnProperty('errorcode')) { $(progressSelector).removeClass('upload-progress').addClass('upload-success'); } else { + tempErrorMessage.className = "message message-warning warning"; + tempErrorMessage.innerHTML = data.result.error; + + $('[data-action="show-error"]').append(tempErrorMessage); $(progressSelector).removeClass('upload-progress').addClass('upload-failure'); } }, diff --git a/app/code/Magento/Webapi/Controller/Soap.php b/app/code/Magento/Webapi/Controller/Soap.php index 0fde56dd6b73b..a449504ee1083 100644 --- a/app/code/Magento/Webapi/Controller/Soap.php +++ b/app/code/Magento/Webapi/Controller/Soap.php @@ -134,7 +134,7 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request) $this->_setResponseBody($responseBody); } else if ($this->_isWsdlListRequest()) { $servicesList = []; - foreach (array_keys($this->_wsdlGenerator->getListOfServices()) as $serviceName) { + foreach ($this->_wsdlGenerator->getListOfServices() as $serviceName) { $servicesList[$serviceName]['wsdl_endpoint'] = $this->_soapServer->getEndpointUri() . '?' . \Magento\Webapi\Model\Soap\Server::REQUEST_PARAM_WSDL . '&services=' . $serviceName; } diff --git a/lib/internal/Magento/Framework/View/Template/Html/Minifier.php b/lib/internal/Magento/Framework/View/Template/Html/Minifier.php index 69bd404606d0a..797fcae985555 100644 --- a/lib/internal/Magento/Framework/View/Template/Html/Minifier.php +++ b/lib/internal/Magento/Framework/View/Template/Html/Minifier.php @@ -131,7 +131,7 @@ public function minify($file) '#(?)[^\n\r]*#', '', preg_replace( - '#(?)#', + '#(?)#', '$1', preg_replace( '#(?)[^\n\r]*#', diff --git a/lib/internal/Magento/Framework/View/Test/Unit/Template/Html/MinifierTest.php b/lib/internal/Magento/Framework/View/Test/Unit/Template/Html/MinifierTest.php index 94fa61e04cbe5..d9f0353451db8 100644 --- a/lib/internal/Magento/Framework/View/Test/Unit/Template/Html/MinifierTest.php +++ b/lib/internal/Magento/Framework/View/Test/Unit/Template/Html/MinifierTest.php @@ -124,6 +124,8 @@ public function testMinify() Test title + + Text Link some text @@ -149,6 +151,8 @@ public function testMinify() //]]> + + inline text @@ -156,7 +160,7 @@ public function testMinify() TEXT; $expectedContent = << Test titleText Link some textsomeMethod(); ?>
inline text + inline text TEXT; $this->appDirectoryMock->expects($this->once())