Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#608 Change data array into array of entity_ids #609

Merged
merged 1 commit into from
Nov 8, 2018
Merged

#608 Change data array into array of entity_ids #609

merged 1 commit into from
Nov 8, 2018

Conversation

DanCarlyon
Copy link

@DanCarlyon DanCarlyon commented Nov 7, 2018

Description

This takes the array of items and extracts the entity_ids for use with the deleteRecords method

Fixed Issues (if relevant)

  1. Sales Order Grid - Array to string conversion exception when running Deltas #608: Sales Order Grid - Array to string conversion exception when running Deltas

Manual testing scenarios

  1. Run a full Data migration from Magento 1.14.2.3 to Magento 2.2.6
  2. Place orders on Magento 1
  3. Run a Delta Data migration

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@victor-v-rad
Copy link
Collaborator

Thank you @DanCarlyon for this pull request. I see $items is always array. So no need to check if it is array or not. I will remove this check after merging pull request if you do not mind.

@DanCarlyon
Copy link
Author

@victor-v-rad That's fine by me, thank you :)

@victor-v-rad victor-v-rad merged commit 87826bb into magento:2.2-develop Nov 8, 2018
victor-v-rad added a commit that referenced this pull request Nov 8, 2018
victor-v-rad added a commit that referenced this pull request Nov 8, 2018
@o-iegorov o-iegorov mentioned this pull request Nov 28, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants