Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No affect on frontend after installing baler #72

Open
Nafisa78 opened this issue Oct 6, 2020 · 7 comments
Open

No affect on frontend after installing baler #72

Nafisa78 opened this issue Oct 6, 2020 · 7 comments

Comments

@Nafisa78
Copy link

Nafisa78 commented Oct 6, 2020

Hello,

I have installed baler, did all necessary configuration and ran all commands.
But i don't see any performance improvement on frontend.

@Tomasz-Silpion
Copy link
Member

Interesting I fall into the same issue today. All I've got is:

baler build
✔ Collected theme/module data 132ms

Optimization is done, but stats have not been implemented in the CLI yet

@Nafisa78
Copy link
Author

Nafisa78 commented Oct 7, 2020

Even i got this message. What does this means?

@Quazz
Copy link

Quazz commented Oct 13, 2020

@Nafisa78 It means something went wrong, it is supposed to loop through your themes and gather info about the JS files.

You can try to run baler build --trace to get a trace file.

@Tomasz-Silpion
Copy link
Member

Nothing wrong there

(220.96285897493362): starting CLI
(222.29880899190903): looking for magento root starting at (...)
(223.66586297750473): starting build command from cli
(227.33184498548508): reading enabled modules from app/etc/config.php
(227.91100698709488): requesting module/theme payload from magento
(235.7881259918213): checking pub/static for deployed themes
(241.58203399181366): found deployed themes: (...)
(242.73591601848602): enabled modules (...)
```

Custom theme is within deploy themes. My custom theme parent is Magento/blank

@Quazz
Copy link

Quazz commented Oct 15, 2020

After enabled modules you should see:

received modules/themes payload from magento: (...)

Followed by much more afterwards as it looks for theme parents, deployed locales, etc And then it should be resolving javascript dependencies.

@Tomasz-Silpion
Copy link
Member

Damn vim, indeed they are there with Baler error created. Message: Failed reading RequireJS config on next page. Thank's a lot. I know where to look now.

@Tomasz-Silpion
Copy link
Member

Ok, at least in my case no effect was caused by native js bundling and minification. After disabling them with:

php bin/magento config:set dev/js/minify_files 0
php bin/magento config:set dev/js/enable_js_bundling 0

and redeployment the output states:

✔ (Gtx/fixero) Created core bundle file 1.8s
⠏ (Gtx/fixero) Minify core bundle and RequireJS config
✔ (Gtx/fixero) Minified core bundle and RequireJS 14.9s

Baler bundle balerbundles/core-bundle.js is visible in website source html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants