Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing escape key confirms the save/license confirmation popup #572

Closed
sivaschenko opened this issue Oct 23, 2019 · 8 comments
Closed
Labels
bug Something isn't working Frontend/UI Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Milestone

Comments

@sivaschenko
Copy link
Member

Preconditions

  1. Install Magento with Adobe Stock Integration
  2. Configure the integration in Stores -> Configuration -> Advanced -> System -> Adobe Stock Integration fieldset

Steps to reproduce

  1. Login to admin panel
  2. Open Magento Media Gallery (i.e. go to Cms -> Pages, edit the page and insert image)
  3. Click "Search Adobe Stock" button to open images grid
  4. Click on any image to expand image preview
  5. Click on "Save Preview" button
  6. Press "Escape" key on the keyboard

Actual result

Image preview is saved

Expected result

Popup should be closed and image should not be saved

@sivaschenko sivaschenko added bug Something isn't working Progress: good first issue Good for newcomers Frontend/UI labels Oct 23, 2019
@sivaschenko sivaschenko added this to the Phase 2: License Images milestone Oct 23, 2019
@konarshankar07
Copy link
Contributor

Hello @sivaschenko ,
I think we need to fix this issue in Magento repo so that the future modal will not have this kind of issue
Let me know your thoughts.
Thanks

@sivaschenko
Copy link
Member Author

@konarshankar07 can you reproduce the same issue with any othe prompts in Magento Admin Panel?

@sivaschenko
Copy link
Member Author

Hi @konarshankar07 would you like to continue working on this issue and identify the backward compatible fix as the intial fix was not accepted to magento2?

@konarshankar07
Copy link
Contributor

Hello @sivaschenko ..
Yes, I will create another PR in magento repo for this issue ASAP
Thanks

@konarshankar07
Copy link
Contributor

Hello @sivaschenko ...
I think this issue has been fixed by someone. I'm not able to reproduce it in latest magento repo or Adobe Stock Integration repo. Please test and let me know if you are able reproduce it.
Thanks

@sivaschenko
Copy link
Member Author

Hi @konarshankar07 I believe it was fixed by you in magento/magento2#25349

However, I am keeping this issue open due to comments in the pull request

@konarshankar07
Copy link
Contributor

Hello @sivaschenko ...
Yes, I know I have fixed this issue but my fix was reverted and then someone has fixed including BIC and I also checked the implementation and someone has fixed with different approach but not mine.
Thanks

@sivaschenko
Copy link
Member Author

Hi @konarshankar07 can you please add a link to commit or pull request of the latest fix for future reference

@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround labels Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend/UI Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Projects
None yet
Development

No branches or pull requests

2 participants