From d722459dc8fa5084eff549ce8cc7923bd91ecae5 Mon Sep 17 00:00:00 2001 From: Ilan Filonenko Date: Thu, 25 Jun 2020 19:45:30 -0700 Subject: [PATCH] fix flaky controller tests (#899) --- .../inferenceservice/controller_test.go | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/pkg/controller/inferenceservice/controller_test.go b/pkg/controller/inferenceservice/controller_test.go index 7a48dc4ab6c..728a3b026e5 100644 --- a/pkg/controller/inferenceservice/controller_test.go +++ b/pkg/controller/inferenceservice/controller_test.go @@ -441,20 +441,6 @@ type SimpleEventWithTime struct { LastTimestamp metav1.Time } -type timeSlice []SimpleEventWithTime - -func (p timeSlice) Len() int { - return len(p) -} - -func (p timeSlice) Less(i, j int) bool { - return p[i].LastTimestamp.Before(&p[j].LastTimestamp) -} - -func (p timeSlice) Swap(i, j int) { - p[i], p[j] = p[j], p[i] -} - func getEvents() []SimpleEvent { events := &v1.EventList{} if err := c.List(context.TODO(), events); err != nil { @@ -464,9 +450,9 @@ func getEvents() []SimpleEvent { if numEvents == 0 { return nil } - sortedEvents := make(timeSlice, 0, numEvents) + sortedEvents := make([]SimpleEventWithTime, 0, numEvents) for _, event := range events.Items { - if event.Reason != "Updated" { // Not checking for updates + if event.Reason != "Updated" && event.Reason != "InternalError" { // Not checking for updates or errors sortedEvents = append(sortedEvents, SimpleEventWithTime{ event: SimpleEvent{ Reason: event.Reason,