Duplex.from({writable, readable}) in object mode incompatibility

[sergey-s-betke]

Please, add properties readableObjectMode, writableObjectMode for compatibility with Duplex.from({writable, readable}) for writable.objectMode === true.

[sergey-s-betke]

Workaround:

const readable: streams.Duplex = new streams.PassThrough({ objectMode: true, emitClose: true });
const writable: NodeJS.WritableStream = vfs.dest(containerDirectoryPath, _options.destOptions);

Object.defineProperty(writable, 'writableObjectMode', { enumerable: true, configurable: true, value: true });

return streams.Duplex.from({ writable, readable });

[mafintosh]

Whats breaking for you without this?

[sergey-s-betke]

I use streams.Duplex.from({ writable, readable }) in my gulp plugin. And this stream must work in object mode, and must accept Vinyl object. Without this workaround duplexify node code create Duplex stream with objectMode == false from streamx streams (gulp dest stream, for example).

[mafintosh]

I see. I dont streamx streams are really meant to be turned into node streams, ie node streams have a ton of stuff.

Would suggest using https://github.com/mafintosh/stream-composer for making the duplex etc.

[sergey-s-betke]

I see. I dont streamx streams are really meant to be turned into node streams, ie node streams have a ton of stuff.

Would suggest using https://github.com/mafintosh/stream-composer for making the duplex etc.

ok, thank You. But can You add typescript types declaration for streamx and stream-composer?.

[mafintosh]

I dont write typescript so wouldnt know how to do that. Feel free to send a PR to help. Its pretty stable these days so few things change.