Add compatibility support for keyf in group command #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thank you for your contribution. |
mafintosh
added a commit
that referenced
this pull request
Apr 8, 2013
Add compatibility support for keyf in group command
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm new to mongojs and relatively new to mongo at all. In the mongo shell I issued a group command as documented on http://docs.mongodb.org/manual/reference/method/db.collection.group/ with a function creating the grouping key. Therefore I used the keyf parameter and passed in a function. Back in my node.js project I copy and pasted the group command from the mongo shell and it did not work since the keyf parameter is not used by mongojs.
Since mongojs should be compatible with mongo, I created a small compatibility patch to support both key and keyf.
Cheers,
Ben