allow "premature close" for non-core streams #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mafintosh#11 The timing of "close" events is implementation-specific. For core streams, it's reliably possible to determine if a close event is coming in advance of the stream actually being "done". However, if a stream doesn't have a _readableState or _writableState property, then it's impossible to determine if the close is "premature" or not.
JakeChampion
approved these changes
Dec 28, 2017
|
This breaks error handling for https://github.com/dominictarr/through which uses close as a "destroy" event. Unsure how to support both patterns |
|
@mafintosh |
@mafintosh the project is archived. And this fix is a deal changer for a project im maintaining. It seems to be fixing a premature close issue. Can we look it up again please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11
The timing of "close" events is implementation-specific. For core
streams, it's reliably possible to determine if a close event is coming
in advance of the stream actually being "done".
However, if a stream doesn't have a _readableState or _writableState
property, then it's impossible to determine if the close is "premature"
or not.