Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name.encode for root #13

Closed
skyrising opened this issue Nov 26, 2017 · 1 comment
Closed

name.encode for root #13

skyrising opened this issue Nov 26, 2017 · 1 comment

Comments

@skyrising
Copy link

name.encode encodes the root domain incorrectly:
'' as 00 00 and '.' as 00 00 00 instead of 00
According to RFC1035 3.1 the first 00 length byte terminates a name.
@pusateri
Copy link
Contributor

pusateri commented Jan 8, 2018

I have a fix for this ready to push up as soon as another pull request is closed.

@pusateri pusateri mentioned this issue Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pusateri @skyrising