Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: HMMRATAC integration #320

Closed
taoliu opened this issue Sep 25, 2019 · 2 comments · Fixed by #521
Closed

Feat: HMMRATAC integration #320

taoliu opened this issue Sep 25, 2019 · 2 comments · Fixed by #521
Assignees
Milestone

Comments

@taoliu
Copy link
Contributor

taoliu commented Sep 25, 2019

HMMRATAC (https://github.com/LiuLabUB/HMMRATAC) is a dedicated peak caller for ATAC-seq data. It is written in JAVA, and it has some shared ideas with MACS2. It can be rewritten in Python3 and be integrated into MACS as a subcommand while dealing with ATAC-seq data.

Describe the solution you'd like

  1. JAVA -> Python3 translation
  2. Share MACS components
  3. Design unit tests

Additional context
Some difficulties: HMMRATAC contains machine learning components such as EM algorithm, and Hidden Markov Models. We may need to introduce more dependencies including scikit-learn, hmmlearn and matplotlib.

@taoliu taoliu added this to the MACS3 milestone Sep 25, 2019
@taoliu taoliu pinned this issue Oct 2, 2019
@hyjforesight
Copy link

Hello @taoliu,
just want to check whether it is available to call HMMRATAC in MACS3 now? I didn't find this sub function in MACS3.
image
Thanks!
Best,
YJ

@taoliu
Copy link
Contributor Author

taoliu commented Apr 15, 2022

@hyjforesight We are developing it in this branch: https://github.com/macs3-project/MACS/tree/feat/macs3/hmmratac Almost there :)

@taoliu taoliu linked a pull request Sep 16, 2022 that will close this issue
@taoliu taoliu unpinned this issue Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants