Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space breaks in Dedication add page break #122

Open
ericawarren opened this issue Aug 10, 2016 · 2 comments
Open

Space breaks in Dedication add page break #122

ericawarren opened this issue Aug 10, 2016 · 2 comments

Comments

@ericawarren
Copy link
Contributor

ericawarren commented Aug 10, 2016

A space break paragraph added to a dedication creates a page break for PDF. See attached samples.
9780765392718_MNU.docx
9780765392718_POD.pdf

@nelliemckesson
Copy link
Contributor

Currently, any paragraph not explicitly marked as a dedication paragraph will trigger a new section to be created, so we need to add handling so that space breaks are seen as part of the dedication (as well as any other section). We'll also need to make sure this isn't going to affect our page breaking rules in any negative ways.

@ericawarren
Copy link
Contributor Author

One option would be to add margin-bottom to the dedication style always, and people should let Bookmaker handle where lines breaks within a paragraph, or use soft breaks if they must (as in this one). Only issue is that MS Cleanup macro currently replaces all soft breaks with hard breaks, but we can find a solution for that I am sure, and then don't have to worry about page breaking rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants