Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: impl std::error::Error for ramhorns::Error #15

Closed
brycefisher opened this issue Dec 3, 2019 · 1 comment · Fixed by #19
Closed

Feature: impl std::error::Error for ramhorns::Error #15

brycefisher opened this issue Dec 3, 2019 · 1 comment · Fixed by #19

Comments

@brycefisher
Copy link

I'd like to use this error type with the custom_error crate which removes a lot of the boilerplate associated with writing error types that are enums of other error types. However, because this crate's Error does not impl std::error::Error, I can't do that.

Could I offer a PR to do this?
@maciejhirsz maciejhirsz mentioned this issue Feb 5, 2020
Merged
@brycefisher
Copy link
Author

Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.6.1 maciejhirsz/ramhorns
1 participant
@brycefisher