Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resp should be resp_json to contain all the pagination responses #9

Closed
lucasjhall opened this issue Dec 21, 2020 · 0 comments · Fixed by #10
Closed

Resp should be resp_json to contain all the pagination responses #9

lucasjhall opened this issue Dec 21, 2020 · 0 comments · Fixed by #10
Assignees
Labels
bug Something isn't working

Comments

@lucasjhall
Copy link

As mentioned by @bryanheinz:
https://github.com/lucasjhall/simpleMDMpy/blob/6ed6180192fa319ef9407cd1bba8f1ce6759430e/SimpleMDMpy/SimpleMDM.py#L46

Should be:

return resp_json

While noting:

...fixing it will require returning a dictionary instead of a requests response, which will be a breaking change. i tried to load the final resp['data']` with resp_data, but got TypeError: 'Response' object does not support item assignment...

@lucasjhall lucasjhall added the bug Something isn't working label Dec 21, 2020
@lucasjhall lucasjhall self-assigned this Dec 21, 2020
@lucasjhall lucasjhall mentioned this issue Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant