Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item var not defined with follow_redirects set #87

Closed
eightnoneone opened this issue Jan 18, 2021 · 5 comments
Closed

item var not defined with follow_redirects set #87

eightnoneone opened this issue Jan 18, 2021 · 5 comments

Comments

@eightnoneone
Copy link

I'm no python dev, but should this line be?

json_data.update({'follow_redirects': True})
instead of
item.update({'follow_redirects': True})

I'm getting this error running 2.0.2
Screen Shot 2021-01-17 at 9 33 00 PM

@erikng
Copy link
Member

erikng commented Jan 18, 2021

No. @bfreezy any ideas on this one?

@erikng
Copy link
Member

erikng commented Jan 18, 2021

Actually yes this might have been a bug in the initial PR by the author. Try it out and report back.

@eightnoneone
Copy link
Author

Well, I didn't really need redirects, so I turned that off. I'll see if I can go back and test it.

@bfreezy
Copy link
Contributor

bfreezy commented Jan 18, 2021

Yep, my mistake. Thanks for catching @eightnoneone

I got a PR up to fix and will test later this week when I return to work.

@erikng
Copy link
Member

erikng commented Mar 1, 2021

I'm going to close this since no one has brought it up for a few months.

@erikng erikng closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants