Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sanitize pages #458

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Feature/sanitize pages #458

wants to merge 15 commits into from

Conversation

zahraa-khalil
Copy link
Contributor

Task:

  • Filter pages' data

Clarification:

  • Page's data is distributed on three components
    ArticleBanner component --> banner
    Volunteering banner component --> secondaryBanner
    HeaderNavigation component --> link

Progress:

  • sanitized "banner" data and its children.
  • "link" data is already handled inside its component, however it originally doesn't send much data.
  • "secondaryBanner" is sent as it is, as it returns null whenever it gets destructed.

Error:

  • Destructuring secondaryBanner returns " cannot read property 'foo' of null "

Status

  • Done

@brindle-forest-pixie
Copy link

Your user site link is: http://zahraa-khalil.charity.m3ntorship.com 💪🏼

@Nilegfx Nilegfx temporarily deployed to m3ntorship-charity-pr-458 June 16, 2020 14:54 Inactive
@zahraa-khalil zahraa-khalil requested a review from elhaw June 16, 2020 16:33
@zahraa-khalil zahraa-khalil added question Further information is requested and removed PR: unreviewed labels Jun 16, 2020
@zahraa-khalil zahraa-khalil linked an issue Jun 17, 2020 that may be closed by this pull request
@zahraa-khalil zahraa-khalil removed the question Further information is requested label Jun 19, 2020
@Nilegfx Nilegfx temporarily deployed to m3ntorship-charity-pr-458 June 20, 2020 15:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitizing Data: Pages
3 participants