add sonarcloud config to main flow

.github/workflows/main_flow.yml

@@ -38,7 +38,22 @@ jobs:
         run: bin/rails db:schema:load
       # Add or replace test runners here
       - name: Run tests
-        run: bin/rake test
+        run: bin/rake
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          args:
+            -Dsonar.projectKey=lytrungtin_url_shortener
+            -Dsonar.organization=lytrungtin
+            -Dsonar.exclusions=/vendor/**
+            -Dsonar.java.file.suffixes=-
+            -Dsonar.c.file.suffixes=-
+            -Dsonar.cpp.file.suffixes=-
+            -Dsonar.objc.file.suffixes=-
+            -Dsonar.ruby.coverage.reportPaths=/home/runner/work/url_shortener/url_shortener/coverage/.resultset.json
   lint:
     runs-on: ubuntu-latest
     steps:
@@ -54,4 +69,4 @@ jobs:
       - name: Security audit application code
         run: bundle exe brakeman -q -w2
       - name: Lint Ruby files
-        run: bundle exec rubocop --parallel
+        run: bundle exec rubocop -A --parallel --require rubocop-rails

Gemfile

@@ -47,5 +47,5 @@ group :development, :test do
   gem 'rubocop'
   gem 'rubocop-rails'
   gem 'rubocop-rake'
-  gem 'simplecov', require: false, group: :test
+  gem 'simplecov', group: :test
 end

test/controllers/redirection_controller_test.rb

@@ -14,6 +14,11 @@ class RedirectionControllerTest < ActionDispatch::IntegrationTest
     assert_response :not_found
   end
 
+  test 'access with invalid slug format should render to not found' do
+    get shortened_url(slug: 'te@@st')
+    assert_response :not_found
+  end
+
   test 'access with not existed slug should render to not found' do
     get shortened_url(slug: '1a2b3c')
     assert_response :not_found

test/test_helper.rb

@@ -3,8 +3,15 @@
 ENV['RAILS_ENV'] ||= 'test'
 require 'simplecov'
 require 'simplecov_json_formatter'
-SimpleCov.formatter = SimpleCov::Formatter::JSONFormatter
-SimpleCov.start
+
+# Generate HTML and JSON reports
+SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new([
+                                                                  SimpleCov::Formatter::HTMLFormatter,
+                                                                  SimpleCov::Formatter::JSONFormatter
+                                                                ])
+SimpleCov.start do
+  enable_coverage :branch
+end
 require_relative '../config/environment'
 require 'rails/test_help'