Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put addon up for adoption? #382

Closed
patocallaghan opened this issue Oct 20, 2020 · 21 comments
Closed

Put addon up for adoption? #382

patocallaghan opened this issue Oct 20, 2020 · 21 comments

Comments

@patocallaghan
Copy link
Contributor

patocallaghan commented Oct 20, 2020

Considering some of the trouble encountered in #381 with finding an admin who can help manage this addon, would it make sense to put this addon up for adoption to the adopted-ember-addons org?

When an original owner no longer has time to maintain the addon, there is a place where the addon can be "put up for adoption." Melanie Sumner has created adopted-ember-addons. See the dedicated #ember-adopted-addons channel in the Ember Discord.

Would you consider allowing us to adopt ember-data-model-fragments so that the addon may continue to provide useful service to the community?

/cc @jakesjews @araddon

@jakesjews
Copy link
Contributor

That is cool with me. I haven't had to much time to work on this so it would probably be for the best.

@patocallaghan
Copy link
Contributor Author

patocallaghan commented Oct 20, 2020

@jakesjews cool, there are a list of things that we'd need done to make it happen (see below). I think ultimately we need to get final sign off from someone at Lytics?

Addon Transfer Checklist

These are the things that need to done to transfer your addon:

  • To get your addon adopted, please ping one of the adopted-ember-addons org owners (@Melanie#1618, @Alon#3707, or @knownasilya#9990) in the Ember Discord chat in the #adopted-ember-addons channel and let them know what repository you'd like to transfer.
  • Once they are aware, complete the Addon Transfer checklist (below).
    • Update the repository field of the package.json to point to the new location.
    • If any demo URL or homepage is referenced, it should be updated. At the very least, file an issue on the repository so the adopter can fix.
    • Ensure Release practices are documented.
    • Add at least one of the adopted-ember-addons org owners (melsumner, alonbukai, or knownasilya) to the maintainers of the package on npm. Make sure they have all admin permissions. Remove other maintainers, if reasonable.
  • After the checklist is complete, transfer the repository to one of them here on GitHub.
  • The org owner is then responsible to transfer the addon to this org (Adopted Ember Addons).

@DingoEatingFuzz
Copy link

Hi, former Lytics employee here. I can get ahold of Lytics and see if they'd be willing to transfer ownership.

@markhayden
Copy link
Contributor

Hi, current Lytics employee here. I'll have a couple of conversations in the morning to make sure there isn't any reason we wouldn't be open to the adoption and then make sure things start moving from there. Thanks!

@patocallaghan
Copy link
Contributor Author

@markhayden any updates?

@jakesjews
Copy link
Contributor

@patocallaghan is a fork an option?

@patocallaghan
Copy link
Contributor Author

@markhayden sorry for an additional ping, is there any update? It appears we are currently blocked from making any contributions to this repo.

@jakesjews that's not ideal and IMHO should only be a last resort. While we could fork the repo, we'd still need to be able to publish the npm package.

@ashyablok
Copy link

@patocallaghan @jakesjews Hi, also current Lytics employee. We'll be working on the steps to get this addon up for adoption during this sprint so expect updates sometime in the next two weeks.

@markhayden
Copy link
Contributor

@jakesjews do you have access to the NPM for this addon? one of the required steps for adoption is:

Add at least one of the adopted-ember-addons org owners (melsumner, alonbukai, or knownasilya) to the maintainers of the package on npm. Make sure they have all admin permissions. Remove other maintainers, if reasonable.

we are having trouble tracking down anyone with access on NPM. thanks!

@DingoEatingFuzz
Copy link

@markhayden I still have npm access.

@DingoEatingFuzz
Copy link

They have all been added as maintainers.

@jakesjews
Copy link
Contributor

I do still have NPM access

@markhayden
Copy link
Contributor

transfer complete. woohoo!

@knownasilya
Copy link
Collaborator

There are a few people with write permissions on the repo, do you want to stay on or be removed?

@workmanw @jakesjews @devinus

@jakesjews
Copy link
Contributor

I'm probably not going to be contributing very much so you can remove me

@patocallaghan
Copy link
Contributor Author

Oh awesome, that turned around quite quickly 😃 Thanks everyone for all your help!

@GuillaumeCisco
Copy link

Who is adopting it?

@patocallaghan
Copy link
Contributor Author

@GuillaumeCisco the Adopted Ember Addons org. I'll aim to get a new beta release out in the next day or two.

@knownasilya
Copy link
Collaborator

Still haven't gotten the npm invite email. Not sure what's going on.

@patocallaghan
Copy link
Contributor Author

Ah okay, I'll reopen the issue until we get the npm invite /cc @DingoEatingFuzz @jakesjews @markhayden

@patocallaghan patocallaghan reopened this Nov 10, 2020
@DingoEatingFuzz
Copy link

@knownasilya and I have been working through this. It seems to be an npm issue that may have been resolved? If not I'll reach out to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants