Fix Rails version comparison #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
previously approved these changes
Nov 10, 2023
MaicolBen
dismissed
their stale review
It fails so we need to support older versions of ruby
MaicolBen
reviewed
Nov 10, 2023
| @@ -2,7 +2,7 @@ module DeviseTokenAuth::Concerns::ActiveRecordSupport | |||
| extend ActiveSupport::Concern | |||
|
|
|||
| included do | |||
| if Rails::VERSION::MAJOR >= 7 && Rails::VERSION::MINOR >= 1 | |||
| if Gem::Version.new(Rails::VERSION::STRING) >= "7.1" | |||
There was a problem hiding this comment.
This fails in ruby < 3.1 with ArgumentError: comparison of Gem::Version with String failed . Maybe try with Rails.gem_version >= Gem::Version.new("7.1.x") ?
There was a problem hiding this comment.
Interesting. There I pushed your suggestion with a minor change to account for pre-release versions
santib
force-pushed
the
fix-version-comparison
branch
from
f9ac49c
to
5728c1a
Compare
|
@MaicolBen hate to bug you about this, but this merge needs to be tagged for a RubyGems release. The graphql_devise update for Rails 7.1 is on hold until there is an updated release from devise_token_auth. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous condition would return false for Rails 8.0, when what we actually want is to always return true for versions > 7.1, right?