-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Airbnb-Typescript Code Guidelines on the Frontend library #502
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one. |
cc @ttannis , I think we need to apply the keep fresh label as well, or we remove the stalebot in this repo. |
I wouldn't remind removing it if we can |
…io#502) * Allow minimum reader count to be configurable * Update popular tables * Revert adding POPULAR_TABLE_MINIMUM_READER_COUNT config * dump dict to str * Add unit test for popular tables * GET request sends query strings not data * Update tests * Use url instead of request param for GET
* Allow minimum reader count to be configurable * Update popular tables * Revert adding POPULAR_TABLE_MINIMUM_READER_COUNT config * dump dict to str * Add unit test for popular tables * GET request sends query strings not data * Update tests * Use url instead of request param for GET
…io#502) * Allow minimum reader count to be configurable * Update popular tables * Revert adding POPULAR_TABLE_MINIMUM_READER_COUNT config * dump dict to str * Add unit test for popular tables * GET request sends query strings not data * Update tests * Use url instead of request param for GET
We have setup code linting with ESLint and added some basic rules like the 'react/recommended' to our project.
To make sure we use best practices, reduce our code review effort and provide the best developer experience for our contributors, I suggest to extend the linting rules with the Airbnb rules for Typescript.
Possible Implementation
This rules are already added on the system, but they trigger warnings at the moment. The work on this ticket would entail removing the warnings so they become errors and one by one, fix those issues.
Context
Following strict coding rules for our code benefits Amundsen as:
The text was updated successfully, but these errors were encountered: