Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Airbnb-Typescript Code Guidelines on the Frontend library #502

Closed
Golodhros opened this issue Jun 9, 2020 · 4 comments
Closed

Adopt Airbnb-Typescript Code Guidelines on the Frontend library #502

Golodhros opened this issue Jun 9, 2020 · 4 comments
Labels
area:frontend From the Frontend folder help wanted Extra attention is needed keep fresh Disables stalebot from closing an issue status:needs_votes Issue or bug fix that needs support from the community to be considered type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements

Comments

@Golodhros
Copy link
Member

We have setup code linting with ESLint and added some basic rules like the 'react/recommended' to our project.

To make sure we use best practices, reduce our code review effort and provide the best developer experience for our contributors, I suggest to extend the linting rules with the Airbnb rules for Typescript.

Possible Implementation

This rules are already added on the system, but they trigger warnings at the moment. The work on this ticket would entail removing the warnings so they become errors and one by one, fix those issues.

Context

Following strict coding rules for our code benefits Amundsen as:

  • We spend less time on code reviews
  • We provide a great developer experience to our contributors, increasing the chances of obtaining more help and reducing churn
  • We signal that we are a serious project that care about code quality and good practices
  • We make subsequent changes easier
@Golodhros Golodhros added help wanted Extra attention is needed Project: Frontend status:needs_votes Issue or bug fix that needs support from the community to be considered type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements labels Jun 9, 2020
@stale
Copy link

stale bot commented Jun 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jun 23, 2020
@stale
Copy link

stale bot commented Jul 15, 2020

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

@stale stale bot closed this as completed Jul 15, 2020
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Jul 15, 2020
@feng-tao feng-tao reopened this Jul 15, 2020
@stale stale bot removed the stale label Jul 15, 2020
@feng-tao
Copy link
Member

cc @ttannis , I think we need to apply the keep fresh label as well, or we remove the stalebot in this repo.

@ttannis
Copy link
Contributor

ttannis commented Jul 17, 2020

cc @ttannis , I think we need to apply the keep fresh label as well, or we remove the stalebot in this repo.

I wouldn't remind removing it if we can

dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
…io#502)

* Allow minimum reader count to be configurable

* Update popular tables

* Revert adding POPULAR_TABLE_MINIMUM_READER_COUNT config

* dump dict to str

* Add unit test for popular tables

* GET request sends query strings not data

* Update tests

* Use url instead of request param for GET
feng-tao pushed a commit that referenced this issue May 7, 2021
* Allow minimum reader count to be configurable

* Update popular tables

* Revert adding POPULAR_TABLE_MINIMUM_READER_COUNT config

* dump dict to str

* Add unit test for popular tables

* GET request sends query strings not data

* Update tests

* Use url instead of request param for GET
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
…io#502)

* Allow minimum reader count to be configurable

* Update popular tables

* Revert adding POPULAR_TABLE_MINIMUM_READER_COUNT config

* dump dict to str

* Add unit test for popular tables

* GET request sends query strings not data

* Update tests

* Use url instead of request param for GET
@Golodhros Golodhros added area:frontend From the Frontend folder and removed Project: Frontend labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder help wanted Extra attention is needed keep fresh Disables stalebot from closing an issue status:needs_votes Issue or bug fix that needs support from the community to be considered type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements
Projects
None yet
Development

No branches or pull requests

3 participants