Adopt Stylelint's Sass Guidelines on the Frontend library

[Golodhros]

We have setup CSS linting with Stylelint and added some basic rules.

To make sure we use styling best practices, reduce our code review effort and provide the best developer experience for our contributors, I suggest to extend the styling rules with the Sass Guidelines. These is an opinionated styleguide for writing sane, maintainable and scalable Sass.

Possible Implementation

In order to do this, we would need to install the dependency following the installation instructions on their repo.

After that, running npm run stylelint will trigger several issues that we would need to solve one by one. The work on this ticket would finish when all the errors and warnings are solved.

Context

Following strict styleguide rules for our code benefits Amundsen as:

• We spend less time on code reviews
• We provide a great developer experience to our contributors, increasing the chances of obtaining more help and reducing churn
• We signal that we are a serious project that care about code quality and good practices
• We make subsequent changes easier

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.