Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reset" button in plugin configurations does nothing #1581

Closed
stefonarch opened this issue Mar 9, 2021 · 3 comments
Closed

"Reset" button in plugin configurations does nothing #1581

stefonarch opened this issue Mar 9, 2021 · 3 comments

Comments

@stefonarch
Copy link
Member

When a plugin is removed settings are lost and it starts with default settings again when added again.
There is a reset button in most (?) plugins, which doesn't do anything.

Expected Behavior

Reset button should reset.

Current Behavior

It is inactive.

Possible Solution

Make it work or just remove it, as there is no real need to reset anything, just remove and readd a plugin will do.
There is also a reset button for the panel itself with the same behavior, it looks as it reloads the panel.

Context

#1576

System Information
  • Distribution & Version: All
@palinek
Copy link
Contributor

palinek commented Mar 10, 2021

AFAIK the reset button is there to bring you back to state from time when the config dialog was created -> so just discard changes currently made, not reset to default values.

Isn't this working somewhere?

@stefonarch
Copy link
Member Author

I actually never used it, but yes, this works apparently. So maybe we can close this.

@elviosak
Copy link
Contributor

AFAIK the reset button is there to bring you back to state from time when the config dialog was created -> so just discard changes currently made, not reset to default values.

Isn't this working somewhere?

from some quick tests:

  • panel works except override icon theme option.
  • worldclock resets the dialog to values from plugin creation (when panel is executed, not when config dialog is opened), and doesn't apply changes to the plugin until something else is changed again.
  • volume, mount and menu plugin does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants