Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Dark Mode #1275

Closed
padorange opened this issue Jul 30, 2023 · 9 comments
Closed

Gnome Dark Mode #1275

padorange opened this issue Jul 30, 2023 · 9 comments

Comments

@padorange
Copy link

Liferea 1.14.4
Debian 12 stable (bookworm)
Gnome 43.6

The FAQ tell dark-mode is automatically selected since 1.14
There should be a problem, with my configuration liferea is not un dark mode and it make difficult to read. ie the number of unread article is invisible.
image

@lwindolf
Copy link
Owner

Works for me using 1.14.4 and GNOME 44.0 (Ubuntu 23.04). I also know it works for a lot of other users. Not sure what is happening in your case though.

Can you run Liferea with --debug-html and provide the output that happens when you switch to/from dark mode?

@padorange
Copy link
Author

i run in debug from console but it produce no output (don't know where is the output file, if any).
But when i switch "live" (before running liferea or after launch liferea) if do nothing in liferea (no change, no output). All other software switch)

@padorange
Copy link
Author

I post too quickly.
Runnng liferea from console as admin (sudo) i got an output to the console.
Running in darkmode show that liferea detect "light mode" :

HTML   : theme color "GTK-COLOR-FG" is FFFFFF
HTML   : theme color "GTK-COLOR-BG" is F6F5F4
HTML   : theme color "GTK-COLOR-LIGHT" is FFFFFF
HTML   : theme color "GTK-COLOR-DARK" is B2ACA6
HTML   : theme color "GTK-COLOR-MID" is D9D6D3
HTML   : theme color "GTK-COLOR-BASE" is F6F5F4
HTML   : theme color "GTK-COLOR-TEXT" is FFFFFF
HTML   : theme color "GTK-COLOR-NORMAL-LINK" is 1B6ACB
HTML   : theme color "GTK-COLOR-VISITED-LINK" is 2E3436
HTML   : Light GTK theme detected.
HTML   : theme color "FEEDLIST_UNREAD_FG" is F6F5F4
HTML   : theme color "FEEDLIST_UNREAD_BG" is B2ACA6
HTML   : Feed list unread CSS: foreground='#F6F5F4' background='#B2ACA6'

@lwindolf
Copy link
Owner

lwindolf commented Aug 1, 2023

@padorange Thanks for posting this trace. Can you do an additional run with --debug-html --debug-conf this should give some more output whether the FreeDesktop.org, GNOME settings or defaulting does happen in your case.

A strange thing in you debug output is

 HTML   : theme color "GTK-COLOR-FG" is FFFFFF
 HTML   : theme color "GTK-COLOR-BG" is F6F5F4

This background against this foreground color sounds weird...

@padorange
Copy link
Author

padorange commented Aug 2, 2023

@lwindolf
GTK-COLOR-FG and BG are weird, there must be very light, but as you can see on my initial message the color seems "normal" for a light mode (except is was in "dark mode").

This new trace give a bit more information.
But when i do "sudo liferea" it launch another "config", i do not have my feeds (just examples) and the color are not exactly the same (the counter for unread messages is more visible but still light-mode) : see a new screenshot...

CONF   : proxy auto detect is configured
CONF   : Manual proxy settings are now NULL:0 NULL:NULL
HTML   : theme color "GTK-COLOR-FG" is FFFFFF
HTML   : theme color "GTK-COLOR-BG" is F6F5F4
HTML   : theme color "GTK-COLOR-LIGHT" is FFFFFF
HTML   : theme color "GTK-COLOR-DARK" is B2ACA6
HTML   : theme color "GTK-COLOR-MID" is D9D6D3
HTML   : theme color "GTK-COLOR-BASE" is F6F5F4
HTML   : theme color "GTK-COLOR-TEXT" is FFFFFF
HTML   : theme color "GTK-COLOR-NORMAL-LINK" is 1B6ACB
HTML   : theme color "GTK-COLOR-VISITED-LINK" is 2E3436
CONF   : GNOME reports color-schema 'default'
CONF   : Determined dark theme mode to be 0
HTML   : Light GTK theme detected.
HTML   : theme color "FEEDLIST_UNREAD_FG" is F6F5F4
HTML   : theme color "FEEDLIST_UNREAD_BG" is B2ACA6
HTML   : Feed list unread CSS: foreground='#F6F5F4' background='#B2ACA6'

CONF   : Scheduling feedlist save
HTML   : theme color "GTK-COLOR-FG" is 2E3436
HTML   : theme color "GTK-COLOR-BG" is F6F5F4
HTML   : theme color "GTK-COLOR-LIGHT" is FFFFFF
HTML   : theme color "GTK-COLOR-DARK" is B2ACA6
HTML   : theme color "GTK-COLOR-MID" is D9D6D3
HTML   : theme color "GTK-COLOR-BASE" is F6F5F4
HTML   : theme color "GTK-COLOR-TEXT" is 2E3436
HTML   : theme color "GTK-COLOR-NORMAL-LINK" is 1B6ACB
HTML   : theme color "GTK-COLOR-VISITED-LINK" is 2E3436
CONF   : GNOME reports color-schema 'default'
CONF   : Determined dark theme mode to be 0
HTML   : Light GTK theme detected.
HTML   : theme color "FEEDLIST_UNREAD_FG" is F6F5F4
HTML   : theme color "FEEDLIST_UNREAD_BG" is B2ACA6

image

@lwindolf
Copy link
Owner

lwindolf commented Aug 2, 2023

@padorange I see, by using sudo you are running liferea as root and with the root GTK/GNOME profile, which does not match your actual user profile. For actual debugging you would need to run liferea from a terminal, but without sudo.

@padorange
Copy link
Author

@lwindolf if i do not use sudo the debugs options output nothing in the terminal.
I do not know where the output is located (if any)

@lwindolf
Copy link
Owner

lwindolf commented Aug 2, 2023

@padorange Debug output only goes to the terminal (to STDOUT), nowhere else. So what you did was fine.

Now the problem seems to be why Liferea does not see the theme switch at all. Technically it listens to the GNOME DConf key for the color schema, but the callback (according to your trace is just never triggered). So color does not change.

Sadly I cannot reproduce this.

@padorange
Copy link
Author

Thanks to have taken time on this.
Perhaps there is a right privilege problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants