Adding some documentation for #184 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lviggiano
reviewed
Mar 2, 2018
| @@ -37,6 +37,16 @@ assertEquals("lime", cfg.bar()); | |||
| assertEquals("orange", cfg.baz()); | |||
| ``` | |||
|
|
|||
| <div class="note info"> | |||
There was a problem hiding this comment.
Thanks, but it's better to avoid html in markdown. I'll merge and remove the html tags.
There was a problem hiding this comment.
My mistake :-), in this case is more than ok! please ignore above comment :)
|
@StFS Why a null value is invalid? Is it always true? Maybe I just want that some configuration property to be null. what do you think? |
|
@StFS I created a group on Telegram https://t.me/ownerapi if you want to join. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the changes made to the handling of null values in properties used to construct config objects (Issue #184).