Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirname() expect 1 but two given. Sometimes give timeout #189

Closed
corentinchap opened this issue Mar 10, 2019 · 4 comments · Fixed by #197
Closed

dirname() expect 1 but two given. Sometimes give timeout #189

corentinchap opened this issue Mar 10, 2019 · 4 comments · Fixed by #197
Assignees

Comments

@corentinchap
Copy link

What steps will reproduce the problem?

Install luya-kickstarter-bootstrap4 through composer
Copy config, link to a database
php index.php migrate
php index.php import
php index.php admin/setup

What do you get instead? (A Screenshot can help us a lot!)

image

LUYA Check ouput (run this script and post the result: luyacheck.php)

$ php index.php health
The directory the health commands is applying to: C:\xampp\htdocs\luya-coiffure-booking
public_html/assets: directory exists already
public_html/storage: directory exists already
migrations: directory exists already
vendor: directory exists already
runtime: directory exists already
configs/env.php: file exists.
public_html/index.php: file exists.
O.K.?[0m?[32m
?[0m

Additional infos

Q A
LUYA Version 1.0.0
PHP Version PHP 5.6.38
Platform XAMPP
Operating system Windows
@corentinchap
Copy link
Author

Used the standard kickstart project with PHP 7 instead, don't have anymore issues

@nadar nadar transferred this issue from luyadev/luya-kickstarter-bootstrap4 Mar 10, 2019
@nadar nadar reopened this Mar 10, 2019
@nadar
Copy link
Contributor

nadar commented Mar 10, 2019

@boehsermoe
Copy link
Member

boehsermoe commented Mar 14, 2019

The 2nd parameter $level is available only in > PHP 7.0. Do we need a PHP 5.6 bc?
http://php.net/manual/en/function.dirname.php

@nadar
Copy link
Contributor

nadar commented Mar 14, 2019

As lot of CLI envs are still using older PHP version we should keep PHP 5.6 - the unit tests for 5.6 are just failing because of newer php unit version. So yes, i think we should keep 5.6 until its a clear requirement for LUYA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants